From: Peter Zijlstra <peterz@infradead.org>
To: David Malcolm <dmalcolm@redhat.com>
Cc: Ard Biesheuvel <ardb@kernel.org>,
linux-toolchains@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Jason Baron <jbaron@akamai.com>,
"Steven Rostedt (VMware)" <rostedt@goodmis.org>
Subject: Re: static_branch/jump_label vs branch merging
Date: Fri, 9 Apr 2021 15:01:50 +0200 [thread overview]
Message-ID: <YHBQPr8q0cx4iUfN@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <YHBCoijoopbsDn29@hirez.programming.kicks-ass.net>
On Fri, Apr 09, 2021 at 02:03:46PM +0200, Peter Zijlstra wrote:
> On Fri, Apr 09, 2021 at 07:55:42AM -0400, David Malcolm wrote:
> > Sorry if this is a dumb question, but does the function attribute:
> > __attribute__ ((pure))
> > help here? It's meant to allow multiple calls to a predicate to be
> > merged - though I'd be nervous of using it here, the predicate isn't
> > 100% pure, since AIUI the whole point of what you've built is for
> > predicates that very rarely change - but can change occasionally.
>
> I actually tried that, but it doesn't seem to work. Given the function
> arguments are all compile time constants it should DTRT AFAICT, but
> alas.
FWIW, I tried the below patch and GCC-10.2.1 on current tip/master.
---
diff --git a/arch/x86/include/asm/jump_label.h b/arch/x86/include/asm/jump_label.h
index 610a05374c02..704438d07bc8 100644
--- a/arch/x86/include/asm/jump_label.h
+++ b/arch/x86/include/asm/jump_label.h
@@ -14,7 +14,7 @@
#include <linux/stringify.h>
#include <linux/types.h>
-static __always_inline bool arch_static_branch(struct static_key * const key, const bool branch)
+static __always_inline __pure bool arch_static_branch(struct static_key * const key, const bool branch)
{
asm_volatile_goto("1:"
".byte " __stringify(BYTES_NOP5) "\n\t"
@@ -30,7 +30,7 @@ static __always_inline bool arch_static_branch(struct static_key * const key, co
return true;
}
-static __always_inline bool arch_static_branch_jump(struct static_key * const key, const bool branch)
+static __always_inline __pure bool arch_static_branch_jump(struct static_key * const key, const bool branch)
{
asm_volatile_goto("1:"
".byte 0xe9\n\t .long %l[l_yes] - 2f\n\t"
diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h
index 05f5554d860f..834086663c26 100644
--- a/include/linux/jump_label.h
+++ b/include/linux/jump_label.h
@@ -195,12 +195,12 @@ struct module;
#define JUMP_TYPE_LINKED 2UL
#define JUMP_TYPE_MASK 3UL
-static __always_inline bool static_key_false(struct static_key *key)
+static __always_inline __pure bool static_key_false(struct static_key * const key)
{
return arch_static_branch(key, false);
}
-static __always_inline bool static_key_true(struct static_key *key)
+static __always_inline __pure bool static_key_true(struct static_key * const key)
{
return !arch_static_branch(key, true);
}
next prev parent reply other threads:[~2021-04-09 13:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 16:52 static_branch/jump_label vs branch merging Peter Zijlstra
2021-04-09 9:57 ` Ard Biesheuvel
2021-04-09 10:55 ` Florian Weimer
2021-04-09 11:16 ` Peter Zijlstra
2021-04-09 19:33 ` Nick Desaulniers
2021-04-09 20:11 ` Peter Zijlstra
2021-04-10 17:02 ` Segher Boessenkool
2021-04-09 11:12 ` Peter Zijlstra
2021-04-09 11:55 ` David Malcolm
2021-04-09 12:03 ` Peter Zijlstra
2021-04-09 13:01 ` Peter Zijlstra [this message]
2021-04-09 13:13 ` Peter Zijlstra
2021-04-09 13:48 ` David Malcolm
2021-04-09 18:40 ` Peter Zijlstra
2021-04-09 19:21 ` David Malcolm
2021-04-09 20:09 ` Peter Zijlstra
2021-04-09 21:07 ` David Malcolm
2021-04-09 21:39 ` Peter Zijlstra
2021-04-22 11:48 ` Peter Zijlstra
2021-04-22 17:08 ` Segher Boessenkool
2021-04-22 17:49 ` Peter Zijlstra
2021-04-22 18:31 ` Segher Boessenkool
2021-04-26 17:13 ` Peter Zijlstra
2021-04-10 12:44 ` David Laight
2021-04-09 13:03 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHBQPr8q0cx4iUfN@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ardb@kernel.org \
--cc=dmalcolm@redhat.com \
--cc=jbaron@akamai.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).