From: Yordan Karadzhov <ykaradzhov@vmware.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH 2/5] kernel-shark-qt: Remove the "Apply to" checkboxes from KsQuickContextMenu
Date: Thu, 10 Jan 2019 15:44:16 +0200 [thread overview]
Message-ID: <20190110134419.20247-3-ykaradzhov@vmware.com> (raw)
In-Reply-To: <20190110134419.20247-1-ykaradzhov@vmware.com>
"Apply to list/graph" checkboxes are available in the "Filter" top menu.
Having the same checkboxes in the Context menu is a potential source of
confusion for the user.
Signed-off-by: Yordan Karadzhov <ykaradzhov@vmware.com>
---
| 30 ----------------------
1 file changed, 30 deletions(-)
--git a/kernel-shark-qt/src/KsQuickContextMenu.cpp b/kernel-shark-qt/src/KsQuickContextMenu.cpp
index b41adb9..4f922a2 100644
--- a/kernel-shark-qt/src/KsQuickContextMenu.cpp
+++ b/kernel-shark-qt/src/KsQuickContextMenu.cpp
@@ -88,36 +88,6 @@ KsQuickContextMenu::KsQuickContextMenu(KsDataStore *data, size_t row,
addSection("Pointer menu");
- if (parentName == "KsTraceViewer") {
- _graphSyncCBox =
- KsUtils::addCheckBoxToMenu(this, "Apply filters to Graph");
-
- connect(_graphSyncCBox, &QCheckBox::stateChanged,
- &KsUtils::graphFilterSync);
-
- /*
- * By defauls the filters will be append to the List (Table)
- * only.
- */
- KsUtils::listFilterSync(true);
- KsUtils::graphFilterSync(false);
- _graphSyncCBox->setChecked(false);
- }
-
- if (parentName == "KsTraceGraph" &&
- (graphs = dynamic_cast<KsTraceGraph *>(parent))) {
- _listSyncCBox =
- KsUtils::addCheckBoxToMenu(this, "Apply filters to List");
-
- connect(_listSyncCBox, &QCheckBox::stateChanged,
- &KsUtils::listFilterSync);
-
- /* By defauls the filters will be append to the Graph only. */
- KsUtils::graphFilterSync(true);
- KsUtils::listFilterSync(false);
- _listSyncCBox->setChecked(false);
- }
-
descr = "Hide task [";
descr += taskName;
descr += "-";
--
2.17.1
next prev parent reply other threads:[~2019-01-10 13:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 13:44 [PATCH 0/5] Cosmetic modifications in KsQuickContextMenu Yordan Karadzhov
2019-01-10 13:44 ` [PATCH 1/5] kernel-shark-qt: Remove _deselectAction from KsQuickContextMenu Yordan Karadzhov
2019-01-10 13:44 ` Yordan Karadzhov [this message]
2019-01-10 13:44 ` [PATCH 3/5] kernel-shark-qt: Rearrange the KsQuickContextMenu menu Yordan Karadzhov
2019-01-10 13:44 ` [PATCH 4/5] kernel-shark-qt: Add "clear all filters" action to KsQuickContextMenu Yordan Karadzhov
2019-01-10 13:44 ` [PATCH 5/5] kernel-shark-qt: Add section separator in KsQuickContextMenu Yordan Karadzhov
2019-01-10 14:31 ` [PATCH 0/5] Cosmetic modifications " Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110134419.20247-3-ykaradzhov@vmware.com \
--to=ykaradzhov@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).