From: Phil Auld <pauld@redhat.com>
To: Slavomir Kaslev <kaslevs@vmware.com>
Cc: rostedt@goodmis.org, linux-trace-devel@vger.kernel.org,
ykaradzhov@vmware.com, jbacik@fb.com, tstoyanov@vmware.com,
slavomir.kaslev@gmail.com
Subject: Re: [PATCH 0/2] Optimize pid filters and add --no-filter option
Date: Mon, 15 Apr 2019 09:59:17 -0400 [thread overview]
Message-ID: <20190415135917.GA22646@pauld.bos.csb> (raw)
In-Reply-To: <20190415104343.31113-1-kaslevs@vmware.com>
On Mon, Apr 15, 2019 at 01:43:41PM +0300 Slavomir Kaslev wrote:
> This patchset optimizes how pid filters are expressed and makes it less likely
> that we overflow ftrace filters' size limit of one page.
>
> Slavomir Kaslev (2):
> trace-cmd: Optimize how pid filters are expressed
> trace-cmd: Add --no-filter option to not filter recording processes
>
> tracecmd/trace-record.c | 126 +++++++++++++++++++++++++++-------------
> tracecmd/trace-usage.c | 1 +
> 2 files changed, 87 insertions(+), 40 deletions(-)
>
> --
> 2.19.1
>
That worked very nicely on my setup. Collapsed from len 6300+ to :
WRITE: /sys/kernel/tracing/events/sched/sched_switch/filter, len 70, data "(common_pid<13247||common_pid>13088)||(next_pid<13247||next_pid>13088)"
--no-filter also worked as advertised.
Thanks!
Acked-by: Phil Auld <pauld@redhat.com>
--
prev parent reply other threads:[~2019-04-15 13:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 10:43 [PATCH 0/2] Optimize pid filters and add --no-filter option Slavomir Kaslev
2019-04-15 10:43 ` [PATCH 1/2] trace-cmd: Optimize how pid filters are expressed Slavomir Kaslev
2019-04-15 15:20 ` Slavomir Kaslev
2019-04-15 10:43 ` [PATCH 2/2] trace-cmd: Add --no-filter option to not filter recording processes Slavomir Kaslev
2019-04-15 13:59 ` Phil Auld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415135917.GA22646@pauld.bos.csb \
--to=pauld@redhat.com \
--cc=jbacik@fb.com \
--cc=kaslevs@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=slavomir.kaslev@gmail.com \
--cc=tstoyanov@vmware.com \
--cc=ykaradzhov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).