linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Yordan Karadzhov <ykaradzhov@vmware.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 0/2] To be included in KS 1.0
Date: Wed, 5 Jun 2019 09:14:48 -0400	[thread overview]
Message-ID: <20190605091448.792d0043@oasis.local.home> (raw)
In-Reply-To: <20190530131330.21701-1-ykaradzhov@vmware.com>

On Thu, 30 May 2019 16:13:28 +0300
Yordan Karadzhov <ykaradzhov@vmware.com> wrote:

> The patch-set contains modifications motivated by the attempt to
> implement a standalone version of the NumPy data interface. Those
> changes do improve the code but strictly speaking are not compulsory
> for KS 1.0. Nevertheless, I would prefer to get those patches upstream
> a.s.a.p. Versions of the two patches have been send already several
> times as part of different other patch-sets.
> 
> Yordan Karadzhov (2):
>   kernel-shark: Add new dataloading method to be used by the NumPu
>     interface
>   kernel-shark: Use full paths for non-standard library headers

Looks good!

Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

> 
>  include/trace-cmd/trace-cmd.h         |   2 +-
>  include/traceevent/event-parse.h      |   2 +-
>  kernel-shark/CMakeLists.txt           |   3 +-
>  kernel-shark/build/FindTraceCmd.cmake |  44 ++++----
>  kernel-shark/src/libkshark-plugin.h   |   2 +-
>  kernel-shark/src/libkshark.c          | 139 ++++++++++++++++++++++++++
>  kernel-shark/src/libkshark.h          |  16 ++-
>  7 files changed, 172 insertions(+), 36 deletions(-)
> 


      parent reply	other threads:[~2019-06-05 13:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-30 13:13 [PATCH 0/2] To be included in KS 1.0 Yordan Karadzhov
2019-05-30 13:13 ` [PATCH 1/2] kernel-shark: Add new dataloading method to be used by the NumPu interface Yordan Karadzhov
2019-05-30 13:13 ` [PATCH 2/2] kernel-shark: Use full paths for non-standard library headers Yordan Karadzhov
2019-06-05 13:14 ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190605091448.792d0043@oasis.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=ykaradzhov@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).