From: Steven Rostedt <rostedt@goodmis.org>
To: Yordan Karadzhov <ykaradzhov@vmware.com>
Cc: linux-trace-devel@vger.kernel.org, y.karadz@gmail.com,
troyengel@gmail.com
Subject: Re: [PATCH 0/2] KernelShark build fixes for v1.0
Date: Wed, 12 Jun 2019 09:34:53 -0400 [thread overview]
Message-ID: <20190612093453.0eefe822@gandalf.local.home> (raw)
In-Reply-To: <20190611152043.22572-1-ykaradzhov@vmware.com>
On Tue, 11 Jun 2019 18:20:41 +0300
Yordan Karadzhov <ykaradzhov@vmware.com> wrote:
> Two patches addressing the problem of having the paths to the build
> directory embedded in the final binaries. The problem was reported
> by Troy Engel.
Hi Troy,
Do these patches work for you?
https://patchwork.kernel.org/patch/10987563/
https://patchwork.kernel.org/patch/10987565/
If so, can I add our "Tested-by"?
Thanks!
-- Steve
>
> Yordan Karadzhov (2):
> kernel-shark: Avoid TRACECMD_BIN_DIR being set to the build path
> kernel-shark: Avoid debug build when CMAKE_BUILD_TYPE=Release
>
> kernel-shark/CMakeLists.txt | 25 ++++++++++++++++---------
> kernel-shark/README | 4 ++--
> kernel-shark/build/FindTraceCmd.cmake | 14 +++++++++-----
> kernel-shark/build/deff.h.cmake | 2 +-
> kernel-shark/src/KsCaptureDialog.cpp | 13 ++++++++-----
> 5 files changed, 36 insertions(+), 22 deletions(-)
>
prev parent reply other threads:[~2019-06-12 13:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 15:20 [PATCH 0/2] KernelShark build fixes for v1.0 Yordan Karadzhov
2019-06-11 15:20 ` [PATCH 1/2] kernel-shark: Avoid TRACECMD_BIN_DIR being set to the build path Yordan Karadzhov
2019-06-11 15:20 ` [PATCH 2/2] kernel-shark: Avoid debug build when CMAKE_BUILD_TYPE=Release Yordan Karadzhov
2019-06-12 13:34 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612093453.0eefe822@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=troyengel@gmail.com \
--cc=y.karadz@gmail.com \
--cc=ykaradzhov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).