linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Slavomir Kaslev <kaslevs@vmware.com>
Cc: "tz.stoyanov@gmail.com" <tz.stoyanov@gmail.com>,
	"linux-trace-devel@vger.kernel.org" 
	<linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH v3] trace-cmd: Add option to execute traced process as given user
Date: Tue, 9 Jul 2019 11:11:11 -0400	[thread overview]
Message-ID: <20190709111111.4a509459@gandalf.local.home> (raw)
In-Reply-To: <81c27b2b509f132aef9efdc37b04a29bf7c9425b.camel@vmware.com>

On Tue, 9 Jul 2019 15:06:42 +0000
Slavomir Kaslev <kaslevs@vmware.com> wrote:

> This is missing a check for allocation failure.
> 
> Other than that, looks great.
> 
> Reviewed-by: Slavomir Kaslev <kaslevs@vmware.com>

I agree with everything Slavomir said. Tzvetomir, care to send a v4?

Thanks!

-- Steve

      reply	other threads:[~2019-07-09 15:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-09 14:29 [PATCH v3] trace-cmd: Add option to execute traced process as given user Tzvetomir Stoyanov (VMware)
2019-07-09 15:06 ` Slavomir Kaslev
2019-07-09 15:11   ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190709111111.4a509459@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=kaslevs@vmware.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=tz.stoyanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).