From: Patrick McLean <chutzpah@gentoo.org>
To: linux-trace-devel@vger.kernel.org
Subject: [PATCH 4/4] trace-cmd: Set SONAME on shared libraries
Date: Fri, 19 Jul 2019 20:03:44 -0700 [thread overview]
Message-ID: <20190720030344.1991393-5-chutzpah@gentoo.org> (raw)
In-Reply-To: <20190720030344.1991393-1-chutzpah@gentoo.org>
From: Patrick McLean <patrick.mclean@sony.com>
Currently trace-cmd installs some shared libraries, but does not set a
SONAME on these. This often violates distro policies, so it should at
least set something.
This patch sets it to the name of the file, which is somewhat naieve,
but works for many libraries. Generally it should be set to have an ABI
version as the extension, so when the developer breaks ABI, they can
change the soname.
Signed-off-by: Patrick McLean <patrick.mclean@sony.com>
---
scripts/utils.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/utils.mk b/scripts/utils.mk
index 260023a..9eb127d 100644
--- a/scripts/utils.mk
+++ b/scripts/utils.mk
@@ -54,7 +54,7 @@ do_build_static_lib = \
do_compile_shared_library = \
($(print_shared_lib_compile) \
- $(CC) --shared $^ -o $@)
+ $(CC) --shared $^ -Wl,-soname,$@ -o $@)
do_compile_plugin_obj = \
($(print_plugin_obj_compile) \
--
2.22.0
prev parent reply other threads:[~2019-07-20 3:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-20 3:03 [PATCH 0/4] trace-cmd: Fixes for packaging Patrick McLean
2019-07-20 3:03 ` [PATCH 1/4] trace-cmd: Allow overriding of python installation directory Patrick McLean
2019-07-20 3:03 ` [PATCH 2/4] trace-cmd: No automagic dependency on udis86 Patrick McLean
2019-07-20 3:17 ` Steven Rostedt
2019-07-23 17:41 ` Patrick McLean
2019-07-20 3:03 ` [PATCH 3/4] trace-cmd: Install all headers needed by kernelshark to proper paths Patrick McLean
2019-07-20 3:03 ` Patrick McLean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190720030344.1991393-5-chutzpah@gentoo.org \
--to=chutzpah@gentoo.org \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).