From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10C9AC2D0B1 for ; Wed, 4 Dec 2019 22:03:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E3FBB22464 for ; Wed, 4 Dec 2019 22:03:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728384AbfLDWDd (ORCPT ); Wed, 4 Dec 2019 17:03:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:37784 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727989AbfLDWDc (ORCPT ); Wed, 4 Dec 2019 17:03:32 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6302021823; Wed, 4 Dec 2019 22:03:31 +0000 (UTC) Date: Wed, 4 Dec 2019 17:03:29 -0500 From: Steven Rostedt To: "Tzvetomir Stoyanov (VMware)" Cc: linux-trace-devel@vger.kernel.org Subject: Re: [PATCH v17 11/18] trace-cmd: Exchange tracing IDs between host and guest Message-ID: <20191204170329.24aaf6bc@gandalf.local.home> In-Reply-To: <20191203103522.482684-12-tz.stoyanov@gmail.com> References: <20191203103522.482684-1-tz.stoyanov@gmail.com> <20191203103522.482684-12-tz.stoyanov@gmail.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Tue, 3 Dec 2019 12:35:15 +0200 "Tzvetomir Stoyanov (VMware)" wrote: > diff --git a/tracecmd/include/trace-local.h b/tracecmd/include/trace-local.h > index 6203e0d..a6f79c5 100644 > --- a/tracecmd/include/trace-local.h > +++ b/tracecmd/include/trace-local.h > @@ -98,8 +98,9 @@ void trace_usage(int argc, char **argv); > > int trace_record_agent(struct tracecmd_msg_handle *msg_handle, > int cpus, int *fds, > - int argc, char **argv, bool use_fifos); > - > + int argc, char **argv, > + bool use_fifos, > + unsigned long long trace_id); I'd keep the empty line between the prototype and the struct declaration below. -- Steve > struct hook_list; > > void trace_init_profile(struct tracecmd_input *handle, struct hook_list *hooks,