From: Steven Rostedt <rostedt@goodmis.org>
To: John Koepi <john.koepi@gmail.com>
Cc: linux-trace-devel@vger.kernel.org, tz.stoyanov@gmail.com
Subject: Re: traceevent support for kernels with CONFIG_GCC_PLUGIN_STRUCTLEAK=y
Date: Thu, 12 Dec 2019 12:25:38 -0500 [thread overview]
Message-ID: <20191212122538.58747672@gandalf.local.home> (raw)
In-Reply-To: <CAJ8z9b0dJrkpDsU8-XWQbVVKqtocCPG+ARO4rkdboxLX_dJ2DA@mail.gmail.com>
On Thu, 12 Dec 2019 19:07:46 +0200
John Koepi <john.koepi@gmail.com> wrote:
> > $ cat /sys/kernel/debug/tracing/events/syscalls/sys_enter_io_submit/format
> > name: sys_enter_io_submit
> > ID: 897
> > format:
> > field:unsigned short common_type; offset:0; size:2; signed:0;
> > ...
> > field:struct iocb __attribute__((user)) * __attribute__((user)) * iocbpp; offset:32; size:8; signed:0;
> > ...
>
> Having __attribute__ leaked into syscalls format, it makes its
> impossible for the traceevent lib from the kernel/tools/lib to
> parse such fields, like in the example above.
>
> This in its turn makes it impossible to use tracing for those syscalls:
>
> > $ sudo perf record -e syscalls:sys_enter_io_submit -aR
> > libtraceevent: No such file or directory
> > Error: expected type 4 but read 5
>
> Thus, tracing does not work for some syscalls in Arch Linux kernels.
> And I suppose for all kernels that built with structleak plugin support.
>
> Reproduce: https://github.com/sitano/traceevent_attribute
>
> My question:
>
> Is it a bug that the traceevent lib does not support parsing __attribute__
> in syscalls formats?
>
> or it is a bug of the SYSCALL_DEFINEx macroses / build system that
> they do allow C attributes to leak?
>
> maybe this is already fixed in the latest kernel? or maybe I am missing
> something?
Thanks for the report. This looks like something we can have
libtraceveent handle, no need to change the kernel.
Could you file a bug report?
https://bugzilla.kernel.org/buglist.cgi?component=Trace-cmd%2FKernelshark&product=Tools&resolution=---
-- Steve
next prev parent reply other threads:[~2019-12-12 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 17:07 traceevent support for kernels with CONFIG_GCC_PLUGIN_STRUCTLEAK=y John Koepi
2019-12-12 17:25 ` Steven Rostedt [this message]
2019-12-14 15:38 ` John Koepi
2020-01-15 18:06 ` [PATCH bpf] traceevent: ignore __attribute__ in fields format Ivan Prisyazhnyy
2020-01-15 18:47 ` John Koepi
2020-01-15 19:31 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212122538.58747672@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=john.koepi@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).