From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24A3FC11D3D for ; Thu, 27 Feb 2020 17:28:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 03AFD24691 for ; Thu, 27 Feb 2020 17:28:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729512AbgB0R2D (ORCPT ); Thu, 27 Feb 2020 12:28:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:46888 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728413AbgB0R2D (ORCPT ); Thu, 27 Feb 2020 12:28:03 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AFBDF24691; Thu, 27 Feb 2020 17:28:02 +0000 (UTC) Date: Thu, 27 Feb 2020 12:28:01 -0500 From: Steven Rostedt To: "Tzvetomir Stoyanov (VMware)" Cc: linux-trace-devel@vger.kernel.org Subject: Re: [PATCH v20 09/15] trace-cmd: Implement new option in trace.dat file: TRACECMD_OPTION_TIME_SHIFT Message-ID: <20200227122801.4e067f90@gandalf.local.home> In-Reply-To: <20200227142001.61577-10-tz.stoyanov@gmail.com> References: <20200227142001.61577-1-tz.stoyanov@gmail.com> <20200227142001.61577-10-tz.stoyanov@gmail.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Thu, 27 Feb 2020 16:19:55 +0200 "Tzvetomir Stoyanov (VMware)" wrote: > + case TRACECMD_OPTION_TIME_SHIFT: > + /* > + * long long int (8 bytes) trace session ID > + * int (4 bytes) count of timestamp offsets. > + * long long array of size [count] of times, > + * when the offsets were calculated. > + * long long array of size [count] of timestamp offsets. > + */ > + if (size < 12 || handle->flags & TRACECMD_FL_IGNORE_DATE) > + break; > + handle->host.trace_id = tep_read_number(handle->pevent, > + buf, 8); > + handle->host.ts_samples_count = tep_read_number(handle->pevent, > + buf + 8, 4); > + samples_size = (8 * handle->host.ts_samples_count); > + if (size != (12 + (2 * samples_size))) { > + warning("Failed to extract Time Shift information from the file, unexpected size %d", size); Probably should show what was expected as well. warning("Failed to extract Time Shift information from the file: found size %d but expected %d", size, 12 + (2 * samples_size)); -- Steve > + break; > + } > + handle->host.ts_samples = malloc(2 * samples_size); > + if (!handle->host.ts_samples) > + return -ENOMEM; > + tsync_offset_load(handle, buf + 12); > + break;