From: Steven Rostedt <rostedt@goodmis.org>
To: Sascha Ortmann <sascha.ortmann@stud.uni-hannover.de>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
linux-trace-devel@vger.kernel.org, linux-kernel@i4.cs.fau.de,
Maximilian Werner <maximilian.werner96@gmail.com>
Subject: Re: [PATCH] tracing/boottime: Fix kprobe multiple events
Date: Wed, 17 Jun 2020 11:05:21 -0400 [thread overview]
Message-ID: <20200617110521.7ed41fdd@oasis.local.home> (raw)
In-Reply-To: <20200617140817.17161-1-sascha.ortmann@stud.uni-hannover.de>
On Wed, 17 Jun 2020 16:08:17 +0200
Sascha Ortmann <sascha.ortmann@stud.uni-hannover.de> wrote:
> Fix boottime kprobe events to add multiple events even if one fails
> and report probe generation failures.
>
> As an example, when we try to set multiprobe kprobe events in
> bootconfig like this:
>
> ftrace.event.kprobes.vfsevents {
> probes = "vfs_read $arg1 $arg2,,
> !error! not reported;?", // leads to error
> "vfs_write $arg1 $arg2"
> }
>
> this will not work like expected. After commit
> da0f1f4167e3af69e1d8b32d6d65195ddd2bfb64 ("tracing/boottime:
> Fix kprobe event API usage"), the function
> trace_boot_add_kprobe_event will not produce any error message,
> aborting the function and stopping subsequent probes from getting
> installed when adding a probe fails at kprobe_event_gen_cmd_start.
> Furthermore, probes continue when kprobe_event_gen_cmd_end fails
> (and kprobe_event_gen_cmd_start did not fail). In this case the
> function even returns successfully when the last call to
> kprobe_event_gen_cmd_end is successful.
>
> The behaviour of reporting and aborting after failures is not
> consistent.
>
> The function trace_boot_add_kprobe_event now continues even when
> one of the multiple events fails. Each failure is now reported
> individually. Since the function can only return one result to the
> caller, the function returns now the last failure (or none, if
> nothing fails).
>
> Cc: linux-kernel@i4.cs.fau.de
> Signed-off-by: Maximilian Werner <maximilian.werner96@gmail.com>
> Signed-off-by: Sascha Ortmann <sascha.ortmann@stud.uni-hannover.de>
Why the double signed off by?
Masami, I'm fine with this, but needs your review.
-- Steve
> ---
> kernel/trace/trace_boot.c | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/kernel/trace/trace_boot.c b/kernel/trace/trace_boot.c
> index 9de29bb45a27..dbb50184e060 100644
> --- a/kernel/trace/trace_boot.c
> +++ b/kernel/trace/trace_boot.c
> @@ -95,18 +95,24 @@ trace_boot_add_kprobe_event(struct xbc_node *node, const char *event)
> struct xbc_node *anode;
> char buf[MAX_BUF_LEN];
> const char *val;
> + int error = 0;
> int ret = 0;
>
> xbc_node_for_each_array_value(node, "probes", anode, val) {
> kprobe_event_cmd_init(&cmd, buf, MAX_BUF_LEN);
>
> - ret = kprobe_event_gen_cmd_start(&cmd, event, val);
> - if (ret)
> - break;
> + error = kprobe_event_gen_cmd_start(&cmd, event, val);
> + if (error) {
> + pr_err("Failed to generate probe: %s\n", buf);
> + ret = error;
> + continue;
> + }
>
> - ret = kprobe_event_gen_cmd_end(&cmd);
> - if (ret)
> + error = kprobe_event_gen_cmd_end(&cmd);
> + if (error) {
> pr_err("Failed to add probe: %s\n", buf);
> + ret = error;
> + }
> }
>
> return ret;
next prev parent reply other threads:[~2020-06-17 15:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 14:08 [PATCH] tracing/boottime: Fix kprobe multiple events Sascha Ortmann
2020-06-17 15:05 ` Steven Rostedt [this message]
2020-06-17 15:06 ` Steven Rostedt
2020-06-17 15:57 ` Maximilian Werner
2020-06-17 16:06 ` Steven Rostedt
2020-06-18 1:50 ` Masami Hiramatsu
2020-06-18 16:33 ` [PATCH v2] " Sascha Ortmann
2020-06-19 1:58 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200617110521.7ed41fdd@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=maximilian.werner96@gmail.com \
--cc=mingo@redhat.com \
--cc=sascha.ortmann@stud.uni-hannover.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).