From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04606C433DF for ; Fri, 3 Jul 2020 16:18:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2AD0208E4 for ; Fri, 3 Jul 2020 16:18:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726670AbgGCQS4 (ORCPT ); Fri, 3 Jul 2020 12:18:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:36310 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726098AbgGCQS4 (ORCPT ); Fri, 3 Jul 2020 12:18:56 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0379220899; Fri, 3 Jul 2020 16:18:54 +0000 (UTC) Date: Fri, 3 Jul 2020 12:18:53 -0400 From: Steven Rostedt To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, linux-trace-devel@vger.kernel.org, Ingo Molnar , Jiri Olsa , Namhyung Kim , Andrew Morton , "Tzvetomir Stoyanov (VMware)" Subject: Re: [PATCH v2 01/15] tools lib traceevent: Add API to read time information from kbuffer Message-ID: <20200703121853.739ee54d@oasis.local.home> In-Reply-To: <20200703113107.GD1320@kernel.org> References: <20200702185344.913492689@goodmis.org> <20200702185703.619656282@goodmis.org> <20200703113107.GD1320@kernel.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Fri, 3 Jul 2020 08:31:07 -0300 Arnaldo Carvalho de Melo wrote: > Em Thu, Jul 02, 2020 at 02:53:45PM -0400, Steven Rostedt escreveu: > > From: "Steven Rostedt (Red Hat)" > > > > Add the functions kbuffer_subbuf_timestamp() and kbuffer_ptr_delta() to get > > the timing data stored in the ring buffer that is used to produced the time > > stamps of the records. > > > > This is useful for tools like trace-cmd to be able to display the content of > > the read data to understand why the records show the time stamps that they > > do. > > > > Link: http://lore.kernel.org/linux-trace-devel/20200625100516.365338-2-tz.stoyanov@gmail.com > > > > Signed-off-by: Steven Rostedt > > [ Ported from trace-cmd.git ] > > Signed-off-by: Tzvetomir Stoyanov (VMware) > > Signed-off-by: Steven Rostedt (VMware) > > Humm, is that intentional, i.e. two signed-off-by you? > Yes. It was originally written by me at Red Hat (thus the "From: Steven Rostedt (Red Hat)"), and that signed-off-by is from Red Hat Steven. Then Tzvetomir ported it over to libtraceveent in the kernel tree, which requires his signed-off-by, and then I pull Tzvetomir's work and the VMware Steven Rostedt signed it off. ;-) As Signed-off-by does have some legal meaning for "right to use this code" I feel it's more than prudent to include both the Red Hat Steven's signed-off-by as well as the VMware Steven's signed-off-by. Make sense? -- Steve