From: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org, namhyung@kernel.org
Subject: [PATCH 8/8] tools lib traceevent: Handle possible strdup() error in tep_add_plugin_path() API
Date: Thu, 16 Jul 2020 12:20:14 +0300 [thread overview]
Message-ID: <20200716092014.2613403-9-tz.stoyanov@gmail.com> (raw)
In-Reply-To: <20200716092014.2613403-1-tz.stoyanov@gmail.com>
Free allocated resources and return -1 in case strdup() fails in
tep_add_plugin_path() API.
Link: https://lore.kernel.org/r/CAM9d7chfvJwodpVrHGc5E2J80peRojmYV_fD8x3cpn9HFRUw2g@mail.gmail.com
Link: https://lore.kernel.org/linux-trace-devel/20200714103027.2477584-9-tz.stoyanov@gmail.com
Suggested-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
tools/lib/traceevent/event-plugin.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/lib/traceevent/event-plugin.c b/tools/lib/traceevent/event-plugin.c
index f0877a7e3e8d..e7c2acb8680f 100644
--- a/tools/lib/traceevent/event-plugin.c
+++ b/tools/lib/traceevent/event-plugin.c
@@ -665,6 +665,10 @@ int tep_add_plugin_path(struct tep_handle *tep, char *path,
return -1;
dir->path = strdup(path);
+ if (!dir->path) {
+ free(dir);
+ return -1;
+ }
dir->prio = prio;
dir->next = tep->plugins_dir;
tep->plugins_dir = dir;
--
2.26.2
next prev parent reply other threads:[~2020-07-16 9:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 9:20 [PATCH 0/8] Backported libtraceevent fixes, suggested by Namhyung Kim Tzvetomir Stoyanov (VMware)
2020-07-16 9:20 ` [PATCH 1/8] tools lib traceevent: Document tep_load_plugins_hook() Tzvetomir Stoyanov (VMware)
2020-07-16 9:20 ` [PATCH 2/8] tools lib traceevent: Handle strdup() error in parse_option_name() Tzvetomir Stoyanov (VMware)
2020-07-16 9:20 ` [PATCH 3/8] tools lib traceevent: Fix typo in tep_plugin_add_option() description Tzvetomir Stoyanov (VMware)
2020-07-16 9:20 ` [PATCH 4/8] tools lib traceevent: Improve error handling of tep_plugin_add_option() API Tzvetomir Stoyanov (VMware)
2020-07-16 9:20 ` [PATCH 5/8] tools lib traceevent: Fixed broken indentation in parse_ip4_print_args() Tzvetomir Stoyanov (VMware)
2020-07-16 9:20 ` [PATCH 6/8] tools lib traceevent: Fixed type in PRINT_FMT_STING Tzvetomir Stoyanov (VMware)
2020-07-16 9:20 ` [PATCH 7/8] tools lib traceevent: Fixed description of tep_add_plugin_path() API Tzvetomir Stoyanov (VMware)
2020-07-16 9:20 ` Tzvetomir Stoyanov (VMware) [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-07-16 9:19 [PATCH 0/8] Backported libtraceevent fixes, suggested by Namhyung Kim Tzvetomir Stoyanov (VMware)
2020-07-16 9:19 ` [PATCH 8/8] tools lib traceevent: Handle possible strdup() error in tep_add_plugin_path() API Tzvetomir Stoyanov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716092014.2613403-9-tz.stoyanov@gmail.com \
--to=tz.stoyanov@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).