From: Steven Rostedt <rostedt@goodmis.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ben Hutchings <ben@decadent.org.uk>, linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] libtraceevent: Fix build with binutils 2.35
Date: Tue, 28 Jul 2020 09:08:06 -0400 [thread overview]
Message-ID: <20200728090806.10e43f96@oasis.local.home> (raw)
In-Reply-To: <20200728121908.GG40195@kernel.org>
On Tue, 28 Jul 2020 09:19:08 -0300
Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Em Sat, Jul 25, 2020 at 02:06:23AM +0100, Ben Hutchings escreveu:
> > In binutils 2.35, 'nm -D' changed to show symbol versions along with
> > symbol names, with the usual @@ separator. When generating
> > libtraceevent-dynamic-list we need just the names, so strip off the
> > version suffix if present.
>
> Steven, have you seen this one?
Yeah, I saw it. Just haven't gotten to it yet ;-)
-- Steve
>
> - Arnaldo
>
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > Cc: stable@vger.kernel.org
> > ---
> > tools/lib/traceevent/plugins/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/lib/traceevent/plugins/Makefile b/tools/lib/traceevent/plugins/Makefile
> > index 349bb81482ab..680d883efe05 100644
> > --- a/tools/lib/traceevent/plugins/Makefile
> > +++ b/tools/lib/traceevent/plugins/Makefile
> > @@ -197,7 +197,7 @@ define do_generate_dynamic_list_file
> > xargs echo "U w W" | tr 'w ' 'W\n' | sort -u | xargs echo`;\
> > if [ "$$symbol_type" = "U W" ];then \
> > (echo '{'; \
> > - $(NM) -u -D $1 | awk 'NF>1 {print "\t"$$2";"}' | sort -u;\
> > + $(NM) -u -D $1 | awk 'NF>1 {sub("@.*", "", $$2); print "\t"$$2";"}' | sort -u;\
> > echo '};'; \
> > ) > $2; \
> > else \
>
>
>
next prev parent reply other threads:[~2020-07-28 13:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-25 1:06 [PATCH] libtraceevent: Fix build with binutils 2.35 Ben Hutchings
2020-07-25 7:06 ` Salvatore Bonaccorso
2020-07-28 12:19 ` Arnaldo Carvalho de Melo
2020-07-28 13:08 ` Steven Rostedt [this message]
2020-07-29 20:59 ` Arnaldo Carvalho de Melo
2020-07-30 0:11 ` Steven Rostedt
2020-07-30 10:02 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728090806.10e43f96@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=acme@kernel.org \
--cc=ben@decadent.org.uk \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).