From: Steven Rostedt <rostedt@goodmis.org>
To: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
Cc: linux-trace-devel@vger.kernel.org, douglas.raillard@arm.com
Subject: Re: [PATCH] trace-cmd: Add flags to APIs for opening trace file
Date: Fri, 5 Feb 2021 09:45:47 -0500 [thread overview]
Message-ID: <20210205094547.05cc8e88@gandalf.local.home> (raw)
In-Reply-To: <20210205075638.1283393-1-tz.stoyanov@gmail.com>
On Fri, 5 Feb 2021 09:56:38 +0200
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:
> +enum tracecmd_open_flags {
> + TRACECMD_FLAG_LOAD_NO_PLUGINS = 1 << 0, /* Do not load plugins */
> + TRACECMD_FLAG_LOAD_NO_SYSTEM_PLUGINS = 1 << 1, /* Do not load system plugins */
> +};
Small nit. It's been standard practice to use "_FL_" instead of "_FLAG_",
just to shorten the length of the name. That's also done in the Linux
kernel.
I can update this, if I don't find any other issues.
Thanks!
-- Steve
prev parent reply other threads:[~2021-02-05 22:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 7:56 [PATCH] trace-cmd: Add flags to APIs for opening trace file Tzvetomir Stoyanov (VMware)
2021-02-05 14:45 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205094547.05cc8e88@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=douglas.raillard@arm.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).