From: Steven Rostedt <rostedt@goodmis.org>
To: Yordan Karadzhov <y.karadz@gmail.com>
Cc: Linux Trace Devel <linux-trace-devel@vger.kernel.org>,
Sameeruddin shaik <sameeruddin.shaik8@gmail.com>
Subject: Re: [PATCH] trace-cmd: Add CODING_STYLE and CONTRIBUTE documents
Date: Tue, 6 Apr 2021 08:39:13 -0400 [thread overview]
Message-ID: <20210406083913.7f7f6d0a@gandalf.local.home> (raw)
In-Reply-To: <7ef527d0-b17e-6292-d8f5-dc730a1751aa@gmail.com>
On Tue, 6 Apr 2021 11:18:07 +0300
Yordan Karadzhov <y.karadz@gmail.com> wrote:
> Maybe we should include an explanation what to do in cases like this:
>
> struct instance_wrapper *iw, **iw_ptr;
>
>
> Let's say, the two are closely related in the code of the function,
> however technically speaking the types are different. Is it OK to have
> both on the same line?
That's one of the cases where I would say it's an exception and not a rule.
Remember this document is a guide not a requirement as I state at the end.
I wouldn't include the above, as it's not common, and it really is a case
by case situation on how to do that, so it is out of scope for this
document.
-- Steve
next prev parent reply other threads:[~2021-04-06 12:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-05 19:19 [PATCH] trace-cmd: Add CODING_STYLE and CONTRIBUTE documents Steven Rostedt
2021-04-06 8:18 ` Yordan Karadzhov
2021-04-06 12:39 ` Steven Rostedt [this message]
2021-04-06 9:37 ` Tzvetomir Stoyanov
2021-04-06 12:47 ` Steven Rostedt
2021-04-07 0:58 ` sameeruddin shaik
2021-04-06 12:36 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210406083913.7f7f6d0a@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=sameeruddin.shaik8@gmail.com \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).