From: Steven Rostedt <rostedt@goodmis.org>
To: Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
Cc: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH 1/2] trace-cmd list: Use tracefs to help find events for -e
Date: Thu, 22 Apr 2021 17:14:43 -0400 [thread overview]
Message-ID: <20210422171443.2d9521b2@gandalf.local.home> (raw)
In-Reply-To: <CAPpZLN6_NjZYmhDMfskxtKOaVrVm+6pa2ic-LrvoKGBN+h=QhQ@mail.gmail.com>
On Mon, 19 Apr 2021 08:10:57 +0300
Tzvetomir Stoyanov <tz.stoyanov@gmail.com> wrote:
> > --- a/lib/trace-cmd/trace-input.c
> > +++ b/lib/trace-cmd/trace-input.c
> > @@ -1234,9 +1234,11 @@ static unsigned long long timestamp_calc(unsigned long long ts, int cpu,
> > ts -= handle->tsc_calc.offset;
> > ts = mul_u64_u32_shr(ts, handle->tsc_calc.mult, handle->tsc_calc.shift);
> > } else {
> > - tracecmd_warning("Timestamp $llu is before the initial offset %llu, set it to 0",
> > + tracecmd_warning("Timestamp %llu is before the initial offset %llu\n"
> > + "\tSetting offset to 0",
> > ts, handle->tsc_calc.offset);
> > - ts = 0;
> > + handle->tsc_calc.offset = 0;
> > + ts = mul_u64_u32_shr(ts, handle->tsc_calc.mult, handle->tsc_calc.shift);
>
> That looks like from a different patch? I'll send v3 from my patch set
> with these fixes.
>
> > }
> > }
Yes, that was leftover from another change that accidentally got committed
into this one. Thanks for noticing. I'll be sending out a v2.
-- Steve
next prev parent reply other threads:[~2021-04-22 21:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 21:30 [PATCH 0/2] trace-cmd list: Include ftrace in event listings Steven Rostedt
2021-04-16 21:30 ` [PATCH 1/2] trace-cmd list: Use tracefs to help find events for -e Steven Rostedt
2021-04-19 5:10 ` Tzvetomir Stoyanov
2021-04-22 21:14 ` Steven Rostedt [this message]
2021-04-16 21:30 ` [PATCH 2/2] trace-cmd list: Add ftrace events to listing of events Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210422171443.2d9521b2@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).