linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 2/2] kernel-shark: Add LatencyPlot plugin
Date: Thu, 6 May 2021 15:33:55 -0400	[thread overview]
Message-ID: <20210506153355.1ca57b06@gandalf.local.home> (raw)
In-Reply-To: <20210429154421.255872-3-y.karadz@gmail.com>

On Thu, 29 Apr 2021 18:44:21 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:

> The plugin allows the user to visualize the latency between two
> events under the condition that the values of given data fields
> in the two events are identical (for example having the same PID).
> The core logic that implements the processing of the data and
> the visualization itself is implemented in:

THIS FEATURE IS FREAKING HOT!!!!

OMG! Seriously Yordan, this is awesome. I could have soooo used this in the
past. I LOVE the way the markers automatically select both the start and
end of the latency. This is a feature that will get a LOT of attention!

WAY TO GO, Yordan!

-- Steve

> 
> src/plugins/latency_plot.h,
> src/plugins/latency_plot.c and
> src/plugins/LatencyPlot.cpp
> 
> The plugin also registers its own dialog, that allows the user to
> select the events (and the matching field) to be visualized. The
> widget of the dialog gets implemented in:
> 
> src/plugins/LatencyPlotDialog.hpp
> src/plugins/LatencyPlotDialog.cpp
> 
> Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>

      reply	other threads:[~2021-05-06 19:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-29 15:44 [PATCH 0/2] New plugins for KS 2.0 Yordan Karadzhov (VMware)
2021-04-29 15:44 ` [PATCH 1/2] kernel-shark: Add EventFieldPlot plugin Yordan Karadzhov (VMware)
2021-04-29 15:44 ` [PATCH 2/2] kernel-shark: Add LatencyPlot plugin Yordan Karadzhov (VMware)
2021-05-06 19:33   ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210506153355.1ca57b06@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=y.karadz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).