From: Steven Rostedt <rostedt@goodmis.org>
To: Yordan Karadzhov <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v2 3/9] kernel-shark: Fix KS_DEFINE_PLUGIN_CONTEXT macro
Date: Mon, 10 May 2021 17:02:34 -0400 [thread overview]
Message-ID: <20210510170234.41c8136a@gandalf.local.home> (raw)
In-Reply-To: <96e06290-f5e8-34ac-1b3e-db8559bffd1f@gmail.com>
On Mon, 10 May 2021 23:34:50 +0300
Yordan Karadzhov <y.karadz@gmail.com> wrote:
> On 10.05.21 г. 22:23, Steven Rostedt wrote:
> > Obviously, I'm missing something to connect the
> > dots.
>
> And I have to admit that the commit message is misleading.
:-)
Yes, please rewrite the commit message to explain exactly what that patch
is doing. That's what threw me for the loop. I read it, and was basing all
my review on what the commit message said, and not what I saw in the patch.
-- Steve
next prev parent reply other threads:[~2021-05-10 21:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 13:47 [PATCH v2 0/9] (Not so) Minor fixes toward KS 2.0 Yordan Karadzhov (VMware)
2021-04-28 13:47 ` [PATCH v2 1/9] kernel-shark: Fix the build for 32b systems Yordan Karadzhov (VMware)
2021-04-28 13:47 ` [PATCH v2 2/9] kernel-shark: Add "cron" job to workflows Yordan Karadzhov (VMware)
2021-04-28 13:47 ` [PATCH v2 3/9] kernel-shark: Fix KS_DEFINE_PLUGIN_CONTEXT macro Yordan Karadzhov (VMware)
2021-05-06 18:11 ` Steven Rostedt
2021-05-10 11:53 ` Yordan Karadzhov
2021-05-10 18:25 ` Steven Rostedt
2021-05-10 18:50 ` Yordan Karadzhov
2021-05-10 19:23 ` Steven Rostedt
2021-05-10 20:18 ` Yordan Karadzhov
2021-05-10 20:34 ` Yordan Karadzhov
2021-05-10 21:02 ` Steven Rostedt [this message]
2021-05-11 13:30 ` Yordan Karadzhov
2021-04-28 13:47 ` [PATCH v2 4/9] kernel-shark: Add cleanup of all plugin contexts Yordan Karadzhov (VMware)
2021-04-28 13:47 ` [PATCH v2 5/9] kernel-shark: Fix memory leak in "sched events" plugin Yordan Karadzhov (VMware)
2021-04-28 13:47 ` [PATCH v2 6/9] kernel-shark: Disable the pop-up offset dialog Yordan Karadzhov (VMware)
2021-04-28 13:47 ` [PATCH v2 7/9] kernel-shark: Remove kvm_combo from the list of default plugins Yordan Karadzhov (VMware)
2021-05-06 18:25 ` Steven Rostedt
2021-05-10 12:15 ` Yordan Karadzhov
2021-04-28 13:47 ` [PATCH v2 8/9] kernel-shark: Remove debugging print out from plugins Yordan Karadzhov (VMware)
2021-04-28 13:47 ` [PATCH v2 9/9] kernel-shark: Hide all plugin internals Yordan Karadzhov (VMware)
2021-05-06 18:26 ` [PATCH v2 0/9] (Not so) Minor fixes toward KS 2.0 Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210510170234.41c8136a@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).