From: Steven Rostedt <rostedt@goodmis.org>
To: Haoran Luo <www@aegistudio.net>
Cc: mingo@redhat.com, linux-trace-devel@vger.kernel.org, security@kernel.org
Subject: Re: [PATCH v2 1/1] tracing: fix bug in rb_per_cpu_empty() that might cause deadloop.
Date: Wed, 21 Jul 2021 09:12:20 -0400 [thread overview]
Message-ID: <20210721091220.0a5c3cbb@oasis.local.home> (raw)
In-Reply-To: <YPeZeEP3oSEUHscl@aegistudio>
On Wed, 21 Jul 2021 03:50:16 +0000
Haoran Luo <www@aegistudio.net> wrote:
> + /*
> + * If writers are committing on the head page, we just need
> + * to care about there're committed data, and the reader will
> + * swap reader page with head page when it is to read data.
> + */
> + if (commit == head)
> + return rb_page_commit(commit) == 0;
> +
> + /*
> + * Writers are committing on page other than reader page and
> + * head page, there should always be content to read.
> + */
> + return false;
> }
>
I like the patch, but could you swap the above two operations. I find
that return conditional in the if condition rather ugly. That is, can
you instead have:
/*
* If writers are committing on a page other than the reader
* page and head page, there should always be content to read.
*/
if (commit != head)
return false;
/*
* Writers are committing on the head page, we just need
* to care about there're committed data, and the reader will
* swap reader page with head page when it is to read data.
*/
return rb_page_commit(commit) == 0;
-- Steve
prev parent reply other threads:[~2021-07-21 13:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 3:50 [PATCH v2 1/1] tracing: fix bug in rb_per_cpu_empty() that might cause deadloop Haoran Luo
2021-07-21 13:12 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210721091220.0a5c3cbb@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=security@kernel.org \
--cc=www@aegistudio.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).