From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: linux-trace-devel@vger.kernel.org
Cc: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Subject: [PATCH] libtracefs: Do not use "or" as function parameter name
Date: Tue, 27 Jul 2021 16:50:30 +0300 [thread overview]
Message-ID: <20210727135030.25914-1-y.karadz@gmail.com> (raw)
"or" is a keyword in C++. Using it as a function argument name in
the public header of the library makes it impossible to include
this header from C++ code.
Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
---
Hi Steven,
This patch is optional. Us it only if it makes sense to you.
Note that this fix is not needed by KernelShark.
Thanks,
Yordan
include/tracefs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/tracefs.h b/include/tracefs.h
index 9cfd257..877e03a 100644
--- a/include/tracefs.h
+++ b/include/tracefs.h
@@ -355,12 +355,12 @@ int tracefs_synth_add_start_filter(struct tracefs_synth *synth,
const char *field,
enum tracefs_synth_compare compare,
const char *val,
- bool neg, bool or);
+ bool neg, bool do_OR);
int tracefs_synth_add_end_filter(struct tracefs_synth *synth,
const char *field,
enum tracefs_synth_compare compare,
const char *val,
- bool neg, bool or);
+ bool neg, bool do_OR);
int tracefs_synth_create(struct tracefs_instance *instance,
struct tracefs_synth *synth);
int tracefs_synth_destroy(struct tracefs_instance *instance,
--
2.30.2
reply other threads:[~2021-07-27 13:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210727135030.25914-1-y.karadz@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).