linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>,
	rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] kernel-shark: Fix compile error: ‘string’ in namespace ‘std’ does not name a type
Date: Mon, 8 Feb 2021 12:34:40 +0200	[thread overview]
Message-ID: <358f4904-ace1-97d6-a325-9a257d36875d@gmail.com> (raw)
In-Reply-To: <20210205111242.57557-1-tz.stoyanov@gmail.com>



On 5.02.21 г. 13:12 ч., Tzvetomir Stoyanov (VMware) wrote:
> From: Tzvetomir (VMware)  Stoyanov <tz.stoyanov@gmail.com>
> 
> There is a compilation error when compiling KernelShark on Fedora 33
> with c++ (GCC) 10.2.1:
> 
>    src/KsPlotTools.hpp:349:37: error: ‘string’ in namespace ‘std’ does not name a type
> 
> "string" should be included in that header file, as it is a direct
> dependency.
> 
> Signed-off-by: Tzvetomir (VMware)  Stoyanov <tz.stoyanov@gmail.com>
> ---
>   src/KsPlotTools.hpp | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/src/KsPlotTools.hpp b/src/KsPlotTools.hpp
> index 1725926..68bd6f7 100644
> --- a/src/KsPlotTools.hpp
> +++ b/src/KsPlotTools.hpp
> @@ -15,6 +15,7 @@
>   // C++
>   #include <forward_list>
>   #include <unordered_map>
> +#include <string>
>   
>   // KernelShark
>   #include "libkshark.h"
> 

Thanks Ceco!

Reviewed-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>

      reply	other threads:[~2021-02-08 10:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05 11:12 [PATCH] kernel-shark: Fix compile error: ‘string’ in namespace ‘std’ does not name a type Tzvetomir Stoyanov (VMware)
2021-02-08 10:34 ` Yordan Karadzhov (VMware) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=358f4904-ace1-97d6-a325-9a257d36875d@gmail.com \
    --to=y.karadz@gmail.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tz.stoyanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).