From: Johannes Berg <johannes@sipsolutions.net>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "linux-trace-devel@vger.kernel.org"
<linux-trace-devel@vger.kernel.org>,
Tzvetomir Stoyanov <tstoyanov@vmware.com>
Subject: Re: trace-cmd python
Date: Sat, 19 Jan 2019 10:12:49 +0100 [thread overview]
Message-ID: <5b9bab6a1749682b80f4642e53567d032b3e4e69.camel@sipsolutions.net> (raw)
In-Reply-To: <20190115094451.119784d5@gandalf.local.home>
Hi,
> DESTDIR is where you want to install it for moving it to another
> machine. If you plan on running trace-cmd on the same machine, but
> having it look elsewhere, then just using prefix should be enough.
Ok. I think it was partially installed due to bash completion failing,
but I see how I can work around that :)
> > If I symlink it to a place where trace-cmd actually looks for it then I
> > get errors in python saying pevent_record_data_get() is not defined, but
>
> Looks to be an old object that it's linking with, as we replaced all
> "pevent_" with "tep_".
No - you forgot to replace it in a few places in the python files :-)
You also forgot to include the new trace-seq.h file into python, so it
was again failing on that.
Patch coming.
johannes
prev parent reply other threads:[~2019-01-19 9:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1524143246.3024.21.camel@sipsolutions.net>
2019-01-04 3:43 ` trace-cmd python Steven Rostedt
2019-01-09 20:36 ` Steven Rostedt
2019-01-15 13:09 ` Johannes Berg
2019-01-15 14:44 ` Steven Rostedt
2019-01-19 9:12 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b9bab6a1749682b80f4642e53567d032b3e4e69.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tstoyanov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).