From: Michal Sojka <michal.sojka@cvut.cz>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Dario Faggioli <dfaggioli@suse.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v2] kernel-shark: Do not hardcode /usr prefix for polkit policies
Date: Wed, 17 Mar 2021 13:59:38 +0100 [thread overview]
Message-ID: <87lfam0wcl.fsf@steelpick.2x.cz> (raw)
In-Reply-To: <1aaeb84b-2820-0818-4ab6-fcfd7b5fa52c@gmail.com>
Hi Yordan,
On Fri, Mar 12 2021, Yordan Karadzhov (VMware) wrote:
> If you are keen to try the latest version, checkout this one:
>
> https://git.kernel.org/pub/scm/utils/trace-cmd/kernel-shark.git/
>
> This is a brand new version that has a lot of changes under the hood and
> needs user testing. We will be extremely happy to receive bug reports ;)
> or patches for this new version.
Great! I've compiled this version and so far everything works. But I use
just basic features - opening the trace, searching and zooming.
On Fri, Mar 12 2021, Yordan Karadzhov (VMware) wrote:
> OK, now I see your problem. Please excuse my ignorance.
>
> Here's the deal. What you want can be achieved with an almost trivial
> patch in kernelshark 2. Have a look here:
>
> https://git.kernel.org/pub/scm/utils/trace-cmd/kernel-shark.git/tree/src/CMakeLists.txt#n129
>
> and make the installation of the policy file to be a separate component.
> Make the installation of "kshark-su-record" part of the new component as
> well since it relies on the policy file.
Sounds good. I'm working on the patch. I'll also send other changes that
will make my life easier.
> I guess "kernelshark.desktop" must be there as well.
I don't think so. Desktop files are looked for at multiple places,
including ~/.local/share/application or $XDG_<SOMETHING>.
-Michal
prev parent reply other threads:[~2021-03-17 13:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 13:12 [PATCH] kernel-shark: Do not hardcode /usr prefix for polkit policies Michal Sojka
2021-03-11 14:09 ` Steven Rostedt
2021-03-11 14:48 ` Michal Sojka
2021-03-11 14:50 ` [PATCH v2] " Michal Sojka
2021-03-11 14:54 ` Steven Rostedt
2021-03-11 17:01 ` Yordan Karadzhov (VMware)
2021-03-11 17:57 ` Michal Sojka
2021-03-12 6:46 ` Yordan Karadzhov (VMware)
2021-03-12 11:47 ` Dario Faggioli
2021-03-12 13:02 ` Yordan Karadzhov (VMware)
2021-03-17 12:59 ` Michal Sojka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfam0wcl.fsf@steelpick.2x.cz \
--to=michal.sojka@cvut.cz \
--cc=dfaggioli@suse.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).