From: Tzvetomir Stoyanov <tstoyanov@vmware.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "linux-trace-devel@vger.kernel.org" <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH 1/3] trace-cmd: Fix typo in Makefile bidr to bdir
Date: Thu, 13 Jun 2019 14:40:55 +0000 [thread overview]
Message-ID: <CACqStocAop3kN18o3+eqx-64uem8dhj-+ewuJ3z9oOxMsZ9rZw@mail.gmail.com> (raw)
In-Reply-To: <20190612182018.861661984@goodmis.org>
On Wed, Jun 12, 2019 at 9:19 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
>
> The order-only prerequisit to $(bdir)/include has a typo of "$(bidr)"
> instead of being "$(bdir)"
>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> ---
Looks OK to me
Reviewed-by: Tzvetomir Stoyanov <tstoyanov@vmware.com>
> tracecmd/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tracecmd/Makefile b/tracecmd/Makefile
> index 93b373d58155..bcd437a26b98 100644
> --- a/tracecmd/Makefile
> +++ b/tracecmd/Makefile
> @@ -47,7 +47,7 @@ all: $(TARGETS)
> $(bdir):
> @mkdir -p $(bdir)
>
> -$(bdir)/include: | $(bidr)
> +$(bdir)/include: | $(bdir)
> @mkdir -p $(bdir)/include
>
> $(TC_VERSION): force | $(bdir)/include
> --
> 2.20.1
>
>
--
Tzvetomir (Ceco) Stoyanov
VMware Open Source Technology Center
next prev parent reply other threads:[~2019-06-13 15:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 18:19 [PATCH 0/3] trace-cmd: Fix some bugs that include issues with --max-graph-depth Steven Rostedt
2019-06-12 18:19 ` [PATCH 1/3] trace-cmd: Fix typo in Makefile bidr to bdir Steven Rostedt
2019-06-13 14:40 ` Tzvetomir Stoyanov [this message]
2019-06-12 18:19 ` [PATCH 2/3] trace-cmd: Have --max-graph-depth only be part of instance Steven Rostedt
2019-06-13 14:48 ` Tzvetomir Stoyanov
2019-06-12 18:19 ` [PATCH 3/3] trace-cmd: Check the return of get_file_content() before calling add_reset_file() Steven Rostedt
2019-06-13 14:51 ` Tzvetomir Stoyanov
2019-06-13 14:51 ` [PATCH 0/3] trace-cmd: Fix some bugs that include issues with --max-graph-depth Slavomir Kaslev
2019-06-13 14:56 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACqStocAop3kN18o3+eqx-64uem8dhj-+ewuJ3z9oOxMsZ9rZw@mail.gmail.com \
--to=tstoyanov@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).