From: Ulf Hansson <ulf.hansson@linaro.org>
To: Raul Rangel <rrangel@chromium.org>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
linux-trace-devel@vger.kernel.org,
Daniel Kurtz <djkurtz@chromium.org>,
zwisler@chromium.org, Steven Rostedt <rostedt@goodmis.org>,
hongjiefang <hongjiefang@asrmicro.com>,
Jennifer Dahm <jennifer.dahm@ni.com>,
Ingo Molnar <mingo@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Shawn Lin <shawn.lin@rock-chips.com>,
Kyle Roeschley <kyle.roeschley@ni.com>,
Avri Altman <avri.altman@wdc.com>,
Simon Horman <horms+renesas@verge.net.au>
Subject: Re: [PATCH v2 0/4] Add trace events for SD registers.
Date: Mon, 29 Apr 2019 11:57:02 +0200 [thread overview]
Message-ID: <CAPDyKFqerMeQey0wJW3Ctohh77CJs6-PxSaR=T6ive_Rx-oMMA@mail.gmail.com> (raw)
In-Reply-To: <20190424153115.GA186956@google.com>
On Wed, 24 Apr 2019 at 17:31, Raul Rangel <rrangel@chromium.org> wrote:
>
> On Tue, Apr 23, 2019 at 08:29:15AM +0200, Ulf Hansson wrote:
> > On Tue, 16 Apr 2019 at 20:33, Raul E Rangel <rrangel@chromium.org> wrote:
> > >
> > > I am not able to make a single event class for all these registers. They
> > > all have different struct sizes and different printf formats.
> > >
> > > Thanks for the reviews!
> > >
> > > Changes in v2:
> > > - Made trace_sd_scr print out flags.
> > > - Add BUILD_BUG_ON to make sure tracing stays in sync with structs.
> > > - memcpy using sizeof(__entry->raw)
> > >
> > > Raul E Rangel (4):
> > > mmc: core: Add trace event for SD SCR response
> > > mmc: core: Add trace event for SD SSR response
> > > mmc: core: Add trace event for SD OCR response
> > > mmc: core: Add trace event for CSD response
> > >
> > > drivers/mmc/core/mmc.c | 4 +
> > > drivers/mmc/core/sd.c | 10 ++
> > > drivers/mmc/core/sd_ops.c | 6 ++
> > > include/trace/events/mmc.h | 204 +++++++++++++++++++++++++++++++++++++
> > > 4 files changed, 224 insertions(+)
> > >
> > > --
> > > 2.21.0.392.gf8f6787159e-goog
> > >
> >
> > Why do you need this? We already have these card registers reflected
> > though sysfs files, isn't that sufficient?
> >
> I was not actually aware that the registers were exposed via sysfs. I
> was debugging a problem where the host controller was returning all
> zeros when reading from the card. I wasn't aware that it was returning
> all zeros until I added tracing. It made it quite easy to diagnose the
> problem by just diffing the two traces.
This sounds like a quite an unusual problem, and I don't think having
the buffers printed via tracing is worth it.
Moreover, we already have tracing per command/request (but don't print
the buffers), that should cover most of error cases during init, don't
you think?
[...]
Kind regards
Uffe
prev parent reply other threads:[~2019-04-29 9:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 18:32 [PATCH v2 0/4] Add trace events for SD registers Raul E Rangel
2019-04-16 18:32 ` [PATCH v2 1/4] mmc: core: Add trace event for SD SCR response Raul E Rangel
2019-04-16 18:32 ` [PATCH v2 2/4] mmc: core: Add trace event for SD SSR response Raul E Rangel
2019-04-16 18:32 ` [PATCH v2 3/4] mmc: core: Add trace event for SD OCR response Raul E Rangel
2019-04-16 18:32 ` [PATCH v2 4/4] mmc: core: Add trace event for CSD response Raul E Rangel
2019-04-23 6:29 ` [PATCH v2 0/4] Add trace events for SD registers Ulf Hansson
2019-04-24 15:31 ` Raul Rangel
2019-04-29 9:57 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFqerMeQey0wJW3Ctohh77CJs6-PxSaR=T6ive_Rx-oMMA@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=avri.altman@wdc.com \
--cc=djkurtz@chromium.org \
--cc=hongjiefang@asrmicro.com \
--cc=horms+renesas@verge.net.au \
--cc=jennifer.dahm@ni.com \
--cc=kyle.roeschley@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=rrangel@chromium.org \
--cc=shawn.lin@rock-chips.com \
--cc=zwisler@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).