From: Carlos Bilbao <carlos.bilbao@amd.com>
To: Anton Ivanov <anton.ivanov@cambridgegreys.com>,
richard@nod.at, johannes@sipsolutions.net
Cc: linux-um@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uml: vector: fix definitios of VECTOR_WRITE and VECTOR_HEADERS
Date: Thu, 9 Feb 2023 12:14:12 -0600 [thread overview]
Message-ID: <e309f543-5307-65a9-e5c9-c2a82a17eb89@amd.com> (raw)
In-Reply-To: <874b2d0c-3500-5c1e-07cd-74f9e91d92d6@cambridgegreys.com>
On 2/9/23 11:33, Anton Ivanov wrote:
> On 09/02/2023 16:19, Carlos Bilbao wrote:
>> Fix definitions of VECTOR_WRITE and VECTOR_HEADERS with proper bitwise
>> operand for bit shift.
>>
>> Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
>> ---
>> arch/um/drivers/vector_user.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/um/drivers/vector_user.h
>> b/arch/um/drivers/vector_user.h
>> index 3a73d17a0161..f7d3956f5c15 100644
>> --- a/arch/um/drivers/vector_user.h
>> +++ b/arch/um/drivers/vector_user.h
>> @@ -68,8 +68,8 @@ struct vector_fds {
>> };
>> #define VECTOR_READ 1
>> -#define VECTOR_WRITE (1 < 1)
>> -#define VECTOR_HEADERS (1 < 2)
>> +#define VECTOR_WRITE (1 << 1)
>> +#define VECTOR_HEADERS (1 << 2)
>> extern struct arglist *uml_parse_vector_ifspec(char *arg);
>
> These are no longer used. They were used in some very early versions
> of the code.
>
> They should just be removed instead of redefined correctly.
>
Ack, sending patch your way.
Thanks,
Carlos
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
prev parent reply other threads:[~2023-02-09 18:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 16:19 [PATCH] uml: vector: fix definitios of VECTOR_WRITE and VECTOR_HEADERS Carlos Bilbao
2023-02-09 17:04 ` Carlos Bilbao
2023-02-09 17:12 ` Anton Ivanov
2023-02-09 17:33 ` Anton Ivanov
2023-02-09 18:14 ` Carlos Bilbao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e309f543-5307-65a9-e5c9-c2a82a17eb89@amd.com \
--to=carlos.bilbao@amd.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).