From: Al Viro <viro@zeniv.linux.org.uk>
To: Miklos Szeredi <mszeredi@redhat.com>
Cc: Amir Goldstein <amir73il@gmail.com>,
overlayfs <linux-unionfs@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ovl: make private mounts longterm
Date: Fri, 22 May 2020 20:56:26 +0100 [thread overview]
Message-ID: <20200522195626.GV23230@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAOssrKfXgpRykVN94EiEy8xT4j+HCedN96i31j9iHomtavFaLA@mail.gmail.com>
On Fri, May 22, 2020 at 08:53:49PM +0200, Miklos Szeredi wrote:
> On Fri, May 22, 2020 at 7:02 PM Amir Goldstein <amir73il@gmail.com> wrote:
> >
> > > > > - mntput(ofs->upper_mnt);
> > > > > - for (i = 1; i < ofs->numlayer; i++) {
> > > > > - iput(ofs->layers[i].trap);
> > > > > - mntput(ofs->layers[i].mnt);
> > > > > +
> > > > > + if (!ofs->layers) {
> > > > > + /* Deal with partial setup */
> > > > > + kern_unmount(ofs->upper_mnt);
> > > > > + } else {
> > > > > + /* Hack! Reuse ofs->layers as a mounts array */
> > > > > + struct vfsmount **mounts = (struct vfsmount **) ofs->layers;
> > > > > +
> > > > > + for (i = 0; i < ofs->numlayer; i++) {
> > > > > + iput(ofs->layers[i].trap);
> > > > > + mounts[i] = ofs->layers[i].mnt;
> > > > > + }
> > > > > + kern_unmount_many(mounts, ofs->numlayer);
> > > > > + kfree(ofs->layers);
> > > >
> > > > That's _way_ too subtle. AFAICS, you rely upon ->upper_mnt == ->layers[0].mnt,
> > > > ->layers[0].trap == NULL, without even mentioning that. And the hack you do
> > > > mention... Yecchhh... How many layers are possible, again?
> > >
> > > 500, mounts array would fit inside a page and a page can be allocated
> > > with __GFP_NOFAIL. But why bother? It's not all that bad, is it?
> >
> > FWIW, it seems fine to me.
> > We can transfer the reference from upperdir_trap to layers[0].trap
> > when initializing layers[0] for the sake of clarity.
>
> Right, we should just get rid of ofs->upper_mnt and ofs->upperdir_trap
> and use ofs->layers[0] to store those.
For that you'd need to allocate ->layers before you get to ovl_get_upper(),
though. I'm not saying it's a bad idea - doing plain memory allocations
before anything else tends to make failure exits cleaner; it's just that
it'll take some massage. Basically, do ovl_split_lowerdirs() early,
then allocate everything you need, then do lookups, etc., filling that
stuff.
Regarding this series - the points regarding the name choice and the
need to document the calling conventions change still remain.
next prev parent reply other threads:[~2020-05-22 19:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 8:57 [PATCH] ovl: make private mounts longterm Miklos Szeredi
2020-05-22 16:08 ` Al Viro
2020-05-22 16:32 ` Miklos Szeredi
2020-05-22 17:02 ` Amir Goldstein
2020-05-22 18:53 ` Miklos Szeredi
2020-05-22 19:56 ` Al Viro [this message]
2020-05-23 4:07 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522195626.GV23230@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=amir73il@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=mszeredi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).