Re: [PATCH v1 2/3] overlay: Add the ability to remount volatile directories when safe

From: kernel test robot <lkp@intel.com>
To: Sargun Dhillon <sargun@sargun.me>,
	linux-unionfs@vger.kernel.org, miklos@szeredi.hu,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Amir Goldstein <amir73il@gmail.com>
Cc: kbuild-all@lists.01.org, Sargun Dhillon <sargun@sargun.me>,
	Giuseppe Scrivano <gscrivan@redhat.com>,
	Vivek Goyal <vgoyal@redhat.com>,
	Daniel J Walsh <dwalsh@redhat.com>,
	linux-fsdevel@vger.kernel.org,
	David Howells <dhowells@redhat.com>
Subject: Re: [PATCH v1 2/3] overlay: Add the ability to remount volatile directories when safe
Date: Wed, 25 Nov 2020 21:29:01 +0800	[thread overview]
Message-ID: <202011252129.jHLWtRgL-lkp@intel.com> (raw)
In-Reply-To: <20201125104621.18838-3-sargun@sargun.me>

[-- Attachment #1: Type: text/plain, Size: 3524 bytes --]

Hi Sargun,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on miklos-vfs/overlayfs-next]
[also build test WARNING on linus/master v5.10-rc5 next-20201125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sargun-Dhillon/Make-overlayfs-volatile-mounts-reusable/20201125-184754
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-next
config: parisc-randconfig-r001-20201125 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/2fee0f742c2bb44771e51ed73ec7faf50165832a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sargun-Dhillon/Make-overlayfs-volatile-mounts-reusable/20201125-184754
        git checkout 2fee0f742c2bb44771e51ed73ec7faf50165832a
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from fs/overlayfs/readdir.c:16:
   fs/overlayfs/readdir.c: In function 'ovl_verify_volatile_info':
>> fs/overlayfs/overlayfs.h:13:21: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'unsigned int' [-Wformat=]
      13 | #define pr_fmt(fmt) "overlayfs: " fmt
         |                     ^~~~~~~~~~~~~
   include/linux/dynamic_debug.h:129:15: note: in expansion of macro 'pr_fmt'
     129 |   func(&id, ##__VA_ARGS__);  \
         |               ^~~~~~~~~~~
   include/linux/dynamic_debug.h:147:2: note: in expansion of macro '__dynamic_func_call'
     147 |  __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
         |  ^~~~~~~~~~~~~~~~~~~
   include/linux/dynamic_debug.h:157:2: note: in expansion of macro '_dynamic_func_call'
     157 |  _dynamic_func_call(fmt, __dynamic_pr_debug,  \
         |  ^~~~~~~~~~~~~~~~~~
   include/linux/printk.h:424:2: note: in expansion of macro 'dynamic_pr_debug'
     424 |  dynamic_pr_debug(fmt, ##__VA_ARGS__)
         |  ^~~~~~~~~~~~~~~~
   fs/overlayfs/readdir.c:1097:3: note: in expansion of macro 'pr_debug'
    1097 |   pr_debug("ovl_volatile_info is of size %d expected %ld\n", err,
         |   ^~~~~~~~
   fs/overlayfs/readdir.c:1097:56: note: format string is defined here
    1097 |   pr_debug("ovl_volatile_info is of size %d expected %ld\n", err,
         |                                                      ~~^
         |                                                        |
         |                                                        long int
         |                                                      %d

vim +13 fs/overlayfs/overlayfs.h

e9be9d5e76e3487 Miklos Szeredi 2014-10-24  11  
1bd0a3aea4357e1 lijiazi        2019-12-16  12  #undef pr_fmt
1bd0a3aea4357e1 lijiazi        2019-12-16 @13  #define pr_fmt(fmt) "overlayfs: " fmt
1bd0a3aea4357e1 lijiazi        2019-12-16  14  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28600 bytes --]