From: Sargun Dhillon <sargun@sargun.me>
To: unlisted-recipients:; (no To-header on input)
Cc: Sargun Dhillon <sargun@sargun.me>,
linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org,
Miklos Szeredi <miklos@szeredi.hu>,
Amir Goldstein <amir73il@gmail.com>
Subject: [PATCH] overlay: Plumb through flush method
Date: Sun, 29 Nov 2020 19:00:39 -0800 [thread overview]
Message-ID: <20201130030039.596801-1-sargun@sargun.me> (raw)
Filesystems can implement their own flush method that release
resources, or manipulate caches. Currently if one of these
filesystems is used with overlayfs, the flush method is not called.
Signed-off-by: Sargun Dhillon <sargun@sargun.me>
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-unionfs@vger.kernel.org
Cc: Miklos Szeredi <miklos@szeredi.hu>
Cc: Amir Goldstein <amir73il@gmail.com>
---
fs/overlayfs/file.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c
index efccb7c1f9bc..802259f33c28 100644
--- a/fs/overlayfs/file.c
+++ b/fs/overlayfs/file.c
@@ -787,6 +787,16 @@ static loff_t ovl_remap_file_range(struct file *file_in, loff_t pos_in,
remap_flags, op);
}
+static int ovl_flush(struct file *file, fl_owner_t id)
+{
+ struct file *realfile = file->private_data;
+
+ if (realfile->f_op->flush)
+ return realfile->f_op->flush(realfile, id);
+
+ return 0;
+}
+
const struct file_operations ovl_file_operations = {
.open = ovl_open,
.release = ovl_release,
@@ -798,6 +808,7 @@ const struct file_operations ovl_file_operations = {
.fallocate = ovl_fallocate,
.fadvise = ovl_fadvise,
.unlocked_ioctl = ovl_ioctl,
+ .flush = ovl_flush,
#ifdef CONFIG_COMPAT
.compat_ioctl = ovl_compat_ioctl,
#endif
--
2.25.1
next reply other threads:[~2020-11-30 3:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 3:00 Sargun Dhillon [this message]
2020-12-03 10:16 ` [PATCH] overlay: Plumb through flush method Sargun Dhillon
2020-12-03 10:32 ` Amir Goldstein
2020-12-03 18:32 ` Sargun Dhillon
2021-01-20 15:24 ` Miklos Szeredi
2021-01-23 12:54 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130030039.596801-1-sargun@sargun.me \
--to=sargun@sargun.me \
--cc=amir73il@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).