From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH 0/2] Test overlayfs readdir cache
Date: Wed, 21 Apr 2021 12:23:15 +0300 [thread overview]
Message-ID: <20210421092317.68716-1-amir73il@gmail.com> (raw)
Eryu,
This extends the generic t_dir_offset2 test to verify
some more test cases and adds a new generic test which
passes on overlayfs (and other fs) on upstream kernel.
The overlayfs specific test fails on upstream kernel
and the fix commit is currently in linux-next.
As usual, you may want to wait with merging until the fix
commit hits upstream.
Miklos,
I had noticed in the test full logs that readdir of
a merged dir behaves strangely - when seeking backwards
to offsets > 0, readdir returns unlinked entries in results.
The test does not fail on that behavior because the test
only asserts that this is not allowed after seek to offset 0.
Knowing the implementation of overlayfs readdir cache this is
not surprising to me, but I wonder if this behavior is POSIX
compliant, and if not, whether we should document it and/or
add a failing test for it.
Thanks,
Amir.
Amir Goldstein (2):
generic: Test readdir of modified directrory
overlay: Test invalidate of readdir cache
src/t_dir_offset2.c | 63 +++++++++++++++++++++++--
tests/generic/700 | 60 ++++++++++++++++++++++++
tests/generic/700.out | 2 +
tests/generic/group | 1 +
tests/overlay/077 | 105 ++++++++++++++++++++++++++++++++++++++++++
tests/overlay/077.out | 2 +
tests/overlay/group | 1 +
7 files changed, 231 insertions(+), 3 deletions(-)
create mode 100755 tests/generic/700
create mode 100644 tests/generic/700.out
create mode 100755 tests/overlay/077
create mode 100644 tests/overlay/077.out
--
2.25.1
next reply other threads:[~2021-04-21 9:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 9:23 Amir Goldstein [this message]
2021-04-21 9:23 ` [PATCH 1/2] generic: Test readdir of modified directrory Amir Goldstein
2021-04-21 9:23 ` [PATCH 2/2] overlay: Test invalidate of readdir cache Amir Goldstein
2021-04-21 9:33 ` Amir Goldstein
2021-04-22 6:23 ` Amir Goldstein
2021-04-22 6:18 ` [PATCH 0/2] Test overlayfs " Amir Goldstein
2021-04-22 7:53 ` Miklos Szeredi
2021-04-22 8:47 ` Amir Goldstein
2021-04-22 9:03 ` Miklos Szeredi
2021-04-23 10:20 ` Amir Goldstein
2021-04-23 19:03 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421092317.68716-1-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).