From: Chengguang Xu <cgxu519@mykernel.net>
To: miklos@szeredi.hu, jack@suse.cz, amir73il@gmail.com
Cc: linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Chengguang Xu <charliecgxu@tencent.com>
Subject: [RFC PATCH V6 7/7] ovl: implement containerized syncfs for overlayfs
Date: Mon, 22 Nov 2021 11:00:38 +0800 [thread overview]
Message-ID: <20211122030038.1938875-8-cgxu519@mykernel.net> (raw)
In-Reply-To: <20211122030038.1938875-1-cgxu519@mykernel.net>
From: Chengguang Xu <charliecgxu@tencent.com>
Now overlayfs can only sync own dirty inodes during syncfs,
so remove unnecessary sync_filesystem() on upper file system.
Signed-off-by: Chengguang Xu <charliecgxu@tencent.com>
---
fs/overlayfs/super.c | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index ccffcd96491d..213b795a6a86 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -292,18 +292,14 @@ static int ovl_sync_fs(struct super_block *sb, int wait)
/*
* Not called for sync(2) call or an emergency sync (SB_I_SKIP_SYNC).
* All the super blocks will be iterated, including upper_sb.
- *
- * If this is a syncfs(2) call, then we do need to call
- * sync_filesystem() on upper_sb, but enough if we do it when being
- * called with wait == 1.
*/
- if (!wait)
- return 0;
-
upper_sb = ovl_upper_mnt(ofs)->mnt_sb;
-
down_read(&upper_sb->s_umount);
- ret = sync_filesystem(upper_sb);
+ if (wait)
+ wait_sb_inodes(upper_sb);
+ if (upper_sb->s_op->sync_fs)
+ upper_sb->s_op->sync_fs(upper_sb, wait);
+ ret = ovl_sync_upper_blockdev(upper_sb, wait);
up_read(&upper_sb->s_umount);
return ret;
--
2.27.0
next prev parent reply other threads:[~2021-11-22 3:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 3:00 [RFC PATCH V6 0/7] implement containerized syncfs for overlayfs Chengguang Xu
2021-11-22 3:00 ` [RFC PATCH V6 1/7] ovl: setup overlayfs' private bdi Chengguang Xu
2021-11-26 8:51 ` Jan Kara
2021-11-22 3:00 ` [RFC PATCH V6 2/7] ovl: mark overlayfs inode dirty when it has upper Chengguang Xu
2021-11-26 9:10 ` Jan Kara
2021-11-26 13:06 ` Chengguang Xu
2021-11-26 14:32 ` Jan Kara
2021-11-22 3:00 ` [RFC PATCH V6 3/7] ovl: implement overlayfs' own ->write_inode operation Chengguang Xu
2021-11-26 9:14 ` Jan Kara
2021-11-26 13:09 ` Chengguang Xu
2021-11-22 3:00 ` [RFC PATCH V6 4/7] ovl: set 'DONTCACHE' flag for overlayfs inode Chengguang Xu
2021-11-26 9:20 ` Jan Kara
2021-11-22 3:00 ` [RFC PATCH V6 5/7] fs: export wait_sb_inodes() Chengguang Xu
2021-11-26 9:20 ` Jan Kara
2021-11-22 3:00 ` [RFC PATCH V6 6/7] ovl: introduce ovl_sync_upper_blockdev() Chengguang Xu
2021-11-26 9:21 ` Jan Kara
2021-11-22 3:00 ` Chengguang Xu [this message]
2021-11-22 7:40 ` [RFC PATCH V6 7/7] ovl: implement containerized syncfs for overlayfs Amir Goldstein
2021-11-26 5:03 ` Chengguang Xu
2021-11-26 9:25 ` Jan Kara
2021-11-27 9:26 ` 回复:[RFC PATCH V6 0/7] " Chengguang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211122030038.1938875-8-cgxu519@mykernel.net \
--to=cgxu519@mykernel.net \
--cc=amir73il@gmail.com \
--cc=charliecgxu@tencent.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).