From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: brauner@kernel.org, amir73il@gmail.com, hu1.chen@intel.com,
malini.bhandaru@intel.com, tim.c.chen@intel.com,
mikko.ylinen@intel.com, lizhen.you@intel.com,
linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/3] overlayfs: Optimize override/revert creds
Date: Wed, 24 Apr 2024 12:01:54 -0700 [thread overview]
Message-ID: <87frvay47x.fsf@intel.com> (raw)
In-Reply-To: <CAJfpeguqW4mPE9UyLmccisTex_gmwq6p9_6_EfVm-1oh6CrEBA@mail.gmail.com>
Miklos Szeredi <miklos@szeredi.hu> writes:
> On Wed, 3 Apr 2024 at 04:18, Vinicius Costa Gomes
> <vinicius.gomes@intel.com> wrote:
>
>> - in ovl_rename() I had to manually call the "light" the overrides,
>> both using the guard() macro or using the non-light version causes
>> the workload to crash the kernel. I still have to investigate why
>> this is happening. Hints are appreciated.
>
> Don't know. Well, there's nesting (in ovl_nlink_end()) but I don't
> see why that should be an issue.
>
> I see why Amir suggested moving away from scoped guards, but that also
> introduces the possibility of subtle bugs if we don't audit every one
> of those sites carefully...
>
> Maybe patchset should be restructured to first do the
> override_creds_light() conversion without guards, and then move over
> to guards. Or the other way round, I don't have a preference. But
> mixing these two independent changes doesn't sound like a great idea
> in any case.
Sounds good. Here's I am thinking:
patch 1: introduce *_creds_light()
patch 2: move backing-file.c to *_creds_light()
patch 3: move overlayfs to *_creds_light()
patch 4: introduce the guard helpers
patch 5: move backing-file.c to the guard helpers
patch 6: move overlayfs to the guard helpers
(and yeah, the subject of the patches will be better than these ;-)
Is this what you had in mind?
Cheers,
--
Vinicius
next prev parent reply other threads:[~2024-04-24 19:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 2:18 [PATCH v1 0/3] overlayfs: Optimize override/revert creds Vinicius Costa Gomes
2024-04-03 2:18 ` [PATCH v1 1/3] cred: Add a light version of override/revert_creds() Vinicius Costa Gomes
2024-04-03 2:18 ` [PATCH v1 2/3] fs: Optimize credentials reference count for backing file ops Vinicius Costa Gomes
2024-04-03 15:40 ` kernel test robot
2024-04-03 2:18 ` [PATCH v1 3/3] overlayfs: Optimize credentials usage Vinicius Costa Gomes
2024-04-12 12:36 ` [PATCH v1 0/3] overlayfs: Optimize override/revert creds Miklos Szeredi
2024-04-24 19:01 ` Vinicius Costa Gomes [this message]
2024-04-25 6:06 ` Amir Goldstein
2024-04-24 17:01 ` Christian Brauner
2024-04-24 19:15 ` Vinicius Costa Gomes
2024-04-25 9:20 ` Christian Brauner
2024-04-25 17:12 ` Vinicius Costa Gomes
2024-04-25 17:47 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frvay47x.fsf@intel.com \
--to=vinicius.gomes@intel.com \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=hu1.chen@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=lizhen.you@intel.com \
--cc=malini.bhandaru@intel.com \
--cc=mikko.ylinen@intel.com \
--cc=miklos@szeredi.hu \
--cc=tim.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).