From: Miklos Szeredi <miklos@szeredi.hu>
To: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
Cc: Amir Goldstein <amir73il@gmail.com>,
Vivek Goyal <vgoyal@redhat.com>,
overlayfs <linux-unionfs@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] ovl: introduce new "uuid=off" option for inodes index feature
Date: Tue, 6 Oct 2020 17:13:25 +0200 [thread overview]
Message-ID: <CAJfpegvgmnWrmsACuWe_hYCfVm2r0Ltv0C+sN+3T1DBMzrGE9w@mail.gmail.com> (raw)
In-Reply-To: <20200925083507.13603-3-ptikhomirov@virtuozzo.com>
On Fri, Sep 25, 2020 at 10:35 AM Pavel Tikhomirov
<ptikhomirov@virtuozzo.com> wrote:
> Note: In our (Virtuozzo) use case users inside a container can create
> "regular" overlayfs mounts without any "index=" option, but we still
> want to migrate this containers with CRIU so we set "index=on" as kernel
> default so that all the container overlayfs mounts get support of file
> handles automatically. With "uuid=off" we want the same thing (to be
> able to "copy" container with uuid change) - we would set kernel default
> so that all the container overlayfs mounts get "uuid=off" automatically.
I'm not sure I buy that argument for a kernel option. It should
rather be a "container" option in that case, but AFAIK the kernel
doesn't have a concept of a container. I think this needs to be
discussed on the relevant mailing lists.
As of now mainline kernel doesn't support unprivileged overlay mounts,
so I guess this is not an issue. Let's just merge this without the
kernel and the module options.
Thanks,
Miklos
next prev parent reply other threads:[~2020-10-06 15:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 8:35 [PATCH v4 0/2] ovl introduce "uuid=off" Pavel Tikhomirov
2020-09-25 8:35 ` [PATCH v4 1/2] ovl: propagate ovl_fs to ovl_decode_real_fh and ovl_encode_real_fh Pavel Tikhomirov
2020-09-25 16:37 ` Amir Goldstein
2020-09-25 8:35 ` [PATCH v4 2/2] ovl: introduce new "uuid=off" option for inodes index feature Pavel Tikhomirov
2020-09-25 16:42 ` Amir Goldstein
2020-09-28 7:22 ` Pavel Tikhomirov
2020-10-06 15:13 ` Miklos Szeredi [this message]
2020-10-13 13:54 ` Pavel Tikhomirov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJfpegvgmnWrmsACuWe_hYCfVm2r0Ltv0C+sN+3T1DBMzrGE9w@mail.gmail.com \
--to=miklos@szeredi.hu \
--cc=amir73il@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=ptikhomirov@virtuozzo.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).