From: Bastien Nocera <hadess@hadess.net>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: Re: [PATCH 4/5] USB: Select better matching USB drivers when available
Date: Wed, 09 Oct 2019 20:24:19 +0200 [thread overview]
Message-ID: <0661117fc2ff5f926443513c6685b72b8f371d14.camel@hadess.net> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1910091324300.1603-100000@iolanthe.rowland.org>
On Wed, 2019-10-09 at 13:28 -0400, Alan Stern wrote:
<snip>
> No, that's not quite it.
>
> Here's what should happen when the subclass driver is being probed:
> First, call the generic_probe routine, and return immediately if that
> fails. Then call the subclass driver's probe routine. If that gets
> an
> error, fail the probe call but tell the device core that the device
> is
> now bound to the generic driver, not to the subclass driver.
So, something like that, on top of the existing patches? (I'm not sure
whether device_driver_attach is the correct call to use here).
- if (udriver->probe)
- return udriver->probe(udev);
- return 0;
+ if (!udriver->probe)
+ return 0;
+ error = udriver->probe(udev);
+ if (error == -ENODEV &&
+ udrv != &usb_generic_driver)
+ return device_driver_attach(usb_generic_driver.drvwrap.driver, dev);
+ return error;
Anything else in this patch series? I was concerned about the naming
for "generic_init" in patch 2 ("subclass").
If there's nothing, I'll test and respin the patchset with the above
changes tomorrow.
Cheers
next prev parent reply other threads:[~2019-10-09 18:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 13:43 [PATCH 0/5] Add Apple MFi fastcharge USB device driver Bastien Nocera
2019-10-09 13:43 ` [PATCH 1/5] USB: Export generic USB device driver functions Bastien Nocera
2019-10-09 13:43 ` [PATCH 2/5] USB: Make it possible to "subclass" usb_device_driver Bastien Nocera
2019-10-09 14:34 ` Alan Stern
2019-10-09 14:41 ` Alan Stern
2019-10-10 8:10 ` Bastien Nocera
2019-10-10 9:58 ` kbuild test robot
2019-10-09 13:43 ` [PATCH 3/5] USB: Implement usb_device_match_id() Bastien Nocera
2019-10-09 14:36 ` Alan Stern
2019-10-09 15:40 ` Bastien Nocera
2019-10-09 17:29 ` Alan Stern
2019-10-09 13:43 ` [PATCH 4/5] USB: Select better matching USB drivers when available Bastien Nocera
2019-10-09 14:43 ` Alan Stern
2019-10-09 15:35 ` Bastien Nocera
2019-10-09 17:28 ` Alan Stern
2019-10-09 18:24 ` Bastien Nocera [this message]
2019-10-09 18:45 ` Alan Stern
2019-10-10 8:26 ` Bastien Nocera
2019-10-10 14:19 ` Alan Stern
2019-10-10 10:33 ` kbuild test robot
2019-10-09 13:43 ` [PATCH 5/5] USB: Add driver to control USB fast charge for iOS devices Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0661117fc2ff5f926443513c6685b72b8f371d14.camel@hadess.net \
--to=hadess@hadess.net \
--cc=benjamin.tissoires@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).