From: David Howells <dhowells@redhat.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: dhowells@redhat.com, viro@zeniv.linux.org.uk,
Casey Schaufler <casey@schaufler-ca.com>,
Stephen Smalley <sds@tycho.nsa.gov>,
nicolas.dichtel@6wind.com, raven@themaw.net,
Christian Brauner <christian@brauner.io>,
keyrings@vger.kernel.org, linux-usb@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/9] Add a general, global device notification watch list [ver #5]
Date: Thu, 04 Jul 2019 17:04:20 +0100 [thread overview]
Message-ID: <10295.1562256260@warthog.procyon.org.uk> (raw)
In-Reply-To: <20190703190846.GA15663@kroah.com>
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> Don't we need a manpage and a kselftest for it?
I've got part of a manpage, but it needs more work.
How do you do a kselftest for this when it does nothing unless hardware events
happen?
> > + u64 id = 0; /* Might want to allow dev# here. */
>
> I don't understand the comment here, what does "dev#" refer to?
This is really for mount subtree watches, so I'm removing it for now.
The reason it's there is because a mount object may have multiple watches, but
each watch is set on a dentry within that mount, and it doesn't have to be the
same dentry each time. The queue is shared between all the dentries, and the
ID is used (a) to label them so that they can be manually removed, (b) to
match them to each dentry when the notification is being propagated rootwards
along the tree and (c) to avoid adding another field to struct dentry.
David
next prev parent reply other threads:[~2019-07-04 16:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 15:48 [PATCH 0/9] Keyrings, Block and USB notifications [ver #5] David Howells
2019-06-28 15:48 ` [PATCH 1/9] uapi: General notification ring definitions " David Howells
2019-07-03 17:08 ` Greg Kroah-Hartman
2019-06-28 15:48 ` [PATCH 2/9] security: Add hooks to rule on setting a watch " David Howells
2019-07-08 18:46 ` Stephen Smalley
2019-06-28 15:49 ` [PATCH 3/9] security: Add a hook for the point of notification insertion " David Howells
2019-07-08 19:13 ` Stephen Smalley
2019-06-28 15:49 ` [PATCH 4/9] General notification queue with user mmap()'able ring buffer " David Howells
2019-07-03 17:11 ` Greg Kroah-Hartman
2019-06-28 15:49 ` [PATCH 5/9] keys: Add a notification facility " David Howells
2019-06-28 15:49 ` [PATCH 6/9] Add a general, global device notification watch list " David Howells
2019-07-03 17:16 ` Greg Kroah-Hartman
2019-07-03 19:08 ` Greg Kroah-Hartman
2019-07-04 16:04 ` David Howells [this message]
2019-07-05 5:17 ` Greg Kroah-Hartman
2019-07-05 8:04 ` David Howells
2019-07-05 8:44 ` Greg Kroah-Hartman
2019-07-05 14:40 ` Alan Stern
2019-06-28 15:49 ` [PATCH 7/9] block: Add block layer notifications " David Howells
2019-06-28 15:49 ` [PATCH 8/9] usb: Add USB subsystem " David Howells
2019-07-03 17:07 ` Greg Kroah-Hartman
2019-06-28 15:49 ` [PATCH 9/9] Add sample notification program " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10295.1562256260@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=casey@schaufler-ca.com \
--cc=christian@brauner.io \
--cc=gregkh@linuxfoundation.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=raven@themaw.net \
--cc=sds@tycho.nsa.gov \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).