From: liulongfang <liulongfang@huawei.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: <mathias.nyman@intel.com>, <stern@rowland.harvard.edu>,
<liudongdong3@huawei.com>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kong.kongxinwei@hisilicon.com>,
<yisen.zhuang@huawei.com>
Subject: Re: [PATCH 1/2] USB:ehci:Add a whitelist for EHCI controllers
Date: Thu, 8 Apr 2021 21:04:17 +0800 [thread overview]
Message-ID: <13446834-afc5-e713-d232-36c771059712@huawei.com> (raw)
In-Reply-To: <YG7LO2DJMThbeJ5W@kroah.com>
On 2021/4/8 17:22, Greg KH Wrote:
> On Thu, Apr 08, 2021 at 05:11:12PM +0800, Longfang Liu wrote:
>> Some types of EHCI controllers do not have SBRN registers.
>> By comparing the white list, the operation of reading the SBRN
>> registers is skipped.
>>
>> Subsequent EHCI controller types without SBRN registers can be
>> directly added to the white list.
>>
>> The current patch does not affect the drive function.
>>
>> Signed-off-by: Longfang Liu <liulongfang@huawei.com>
>> ---
>> drivers/usb/host/ehci-pci.c | 27 +++++++++++++++++++++++----
>> 1 file changed, 23 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
>> index 3c3820a..6a30afa 100644
>> --- a/drivers/usb/host/ehci-pci.c
>> +++ b/drivers/usb/host/ehci-pci.c
>> @@ -47,6 +47,28 @@ static inline bool is_bypassed_id(struct pci_dev *pdev)
>> return !!pci_match_id(bypass_pci_id_table, pdev);
>> }
>>
>> +static const struct usb_nosbrn_whitelist_entry {
>> + unsigned short vendor;
>> + unsigned short device;
>
> u16 here please.
>
>> +} usb_nosbrn_whitelist[] = {
>> + /* STMICRO ConneXT has no sbrn register */
>> + {PCI_VENDOR_ID_STMICRO, PCI_DEVICE_ID_STMICRO_USB_HOST},
>> + {}
>
> trailing , please.
>
Is it necessary to add "," at the end here?
>> +};
>> +
>> +static bool usb_nosbrn_whitelist_check(struct pci_dev *pdev)
>> +{
>> + const struct usb_nosbrn_whitelist_entry *entry;
>> +
>> + for (entry = usb_nosbrn_whitelist; entry->vendor; entry++) {
>> + if (pdev->vendor == entry->vendor &&
>> + pdev->device == entry->device)
>> + return true;
>> + }
>> +
>> + return false;
>> +}
>> +
>> /*
>> * 0x84 is the offset of in/out threshold register,
>> * and it is the same offset as the register of 'hostpc'.
>> @@ -288,10 +310,7 @@ static int ehci_pci_setup(struct usb_hcd *hcd)
>> }
>>
>> /* Serial Bus Release Number is at PCI 0x60 offset */
>> - if (pdev->vendor == PCI_VENDOR_ID_STMICRO
>> - && pdev->device == PCI_DEVICE_ID_STMICRO_USB_HOST)
>> - ; /* ConneXT has no sbrn register */
>> - else
>> + if (!usb_nosbrn_whitelist_check(pdev))
>
> Doing this as a "negative" is hard to understand. Should this just be:
> forbid_sbrn_read()
> or something like that?
>
> The term "whitelist" is not a good thing to use as it does not really
> explain anything here.
>
> thanks,
>
> greg k-h
> .
>
Thanks
Longfang.
next prev parent reply other threads:[~2021-04-08 13:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 9:11 [PATCH 0/2] USB:ehci:fix the no SRBN register problem Longfang Liu
2021-04-08 9:11 ` [PATCH 1/2] USB:ehci:Add a whitelist for EHCI controllers Longfang Liu
2021-04-08 9:22 ` Greg KH
2021-04-08 13:04 ` liulongfang [this message]
2021-04-08 14:53 ` Greg KH
2021-04-08 9:33 ` Oliver Neukum
2021-04-08 9:44 ` liulongfang
2021-04-08 9:11 ` [PATCH 2/2] USB:ehci:fix Kunpeng920 ehci hardware problem Longfang Liu
-- strict thread matches above, loose matches on Subject: below --
2021-04-08 9:09 [PATCH 0/2] USB:ehci:fix the no SRBN register problem Longfang Liu
2021-04-08 9:09 ` [PATCH 1/2] USB:ehci:Add a whitelist for EHCI controllers Longfang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13446834-afc5-e713-d232-36c771059712@huawei.com \
--to=liulongfang@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=kong.kongxinwei@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=mathias.nyman@intel.com \
--cc=stern@rowland.harvard.edu \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).