From: liulongfang <liulongfang@huawei.com>
To: <gregkh@linuxfoundation.org>, <mathias.nyman@intel.com>,
<stern@rowland.harvard.edu>, <liudongdong3@huawei.com>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kong.kongxinwei@hisilicon.com>, <yisen.zhuang@huawei.com>
Subject: Re: [PATCH] USB:ehci:fix ehci hardware problem
Date: Thu, 8 Apr 2021 15:19:55 +0800 [thread overview]
Message-ID: <177a1fbd-b6f0-2e67-2e5a-5b05d2015b3a@huawei.com> (raw)
In-Reply-To: <1617865425-28782-1-git-send-email-liulongfang@huawei.com>
On 2021/4/8 15:03, Longfang Liu wrote:
> When rebooting the EHCI driver, ehci_shutdown() will be called.
> if the sbrn flag is 0, ehci_shutdown() will return directly.
>
> Our EHCI hardware does not define the SBRN register, which cause
> its value to default to 0. The sbrn flag being 0 will cause the
> EHCI interrupt signal to not be turned off after reboot. An interrupt
> that is not closed will cause an exception to the device sharing
> the interrupt.
>
> Currently, our hardware has this problem. We hope to solve this
> problem by skipping reading the sbrn register value. On the next
> generation of hardware, we will define this SBRN register in accordance
> with the controller standard.
>
> Signed-off-by: Longfang Liu <liulongfang@huawei.com>
> ---
> drivers/usb/host/ehci-pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
> index 3c3820a..5dc6821 100644
> --- a/drivers/usb/host/ehci-pci.c
> +++ b/drivers/usb/host/ehci-pci.c
> @@ -291,6 +291,8 @@ static int ehci_pci_setup(struct usb_hcd *hcd)
> if (pdev->vendor == PCI_VENDOR_ID_STMICRO
> && pdev->device == PCI_DEVICE_ID_STMICRO_USB_HOST)
> ; /* ConneXT has no sbrn register */
> + else if (pdev->vendor == PCI_VENDOR_ID_HUAWEI)
> + ; /* sbrn register is undefined */
> else
> pci_read_config_byte(pdev, 0x60, &ehci->sbrn);
>
>
Sorry, please ignore this patch, I will resend it.
Thanks.
Longfang.
next prev parent reply other threads:[~2021-04-08 7:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 7:03 [PATCH] USB:ehci:fix ehci hardware problem Longfang Liu
2021-04-08 7:19 ` liulongfang [this message]
2021-04-08 9:09 [PATCH 0/2] USB:ehci:fix the no SRBN register problem Longfang Liu
2021-04-08 9:09 ` [PATCH] USB:ehci:fix ehci hardware problem Longfang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177a1fbd-b6f0-2e67-2e5a-5b05d2015b3a@huawei.com \
--to=liulongfang@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=kong.kongxinwei@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=mathias.nyman@intel.com \
--cc=stern@rowland.harvard.edu \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).