From: Marek Szyprowski <m.szyprowski@samsung.com>
To: linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Kishon Vijay Abraham I <kishon@ti.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH RESEND] phy: exynos5-usbdrd: Calibrating makes sense only for USB2.0 PHY
Date: Mon, 13 Jan 2020 15:02:04 +0100 [thread overview]
Message-ID: <1c5da6e3-d62e-9aa9-8c0c-e028c2c8c444@samsung.com> (raw)
In-Reply-To: <20191213083157.9220-1-m.szyprowski@samsung.com>
On 13.12.2019 09:31, Marek Szyprowski wrote:
> PHY calibration is needed only for USB2.0 (UTMI) PHY, so skip calling
> calibration code when phy_calibrate() is called for USB3.0 (PIPE3) PHY.
>
> Fixes: d8c80bb3b55b ("phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800")
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
gentle ping
> ---
> drivers/phy/samsung/phy-exynos5-usbdrd.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c
> index 646259bee909..f07edd80d2f3 100644
> --- a/drivers/phy/samsung/phy-exynos5-usbdrd.c
> +++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c
> @@ -714,7 +714,9 @@ static int exynos5_usbdrd_phy_calibrate(struct phy *phy)
> struct phy_usb_instance *inst = phy_get_drvdata(phy);
> struct exynos5_usbdrd_phy *phy_drd = to_usbdrd_phy(inst);
>
> - return exynos5420_usbdrd_phy_calibrate(phy_drd);
> + if (inst->phy_cfg->id == EXYNOS5_DRDPHY_UTMI)
> + return exynos5420_usbdrd_phy_calibrate(phy_drd);
> + return 0;
> }
>
> static const struct phy_ops exynos5_usbdrd_phy_ops = {
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2020-01-13 14:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191213083209eucas1p1459831639297fc7c37089c8fef4e0248@eucas1p1.samsung.com>
2019-12-13 8:31 ` [PATCH RESEND] phy: exynos5-usbdrd: Calibrating makes sense only for USB2.0 PHY Marek Szyprowski
2020-01-13 14:02 ` Marek Szyprowski [this message]
[not found] <CGME20200708133811eucas1p1df7b92d7e0ba512c5a7ecdb948edbfcf@eucas1p1.samsung.com>
2020-07-08 13:38 ` Marek Szyprowski
2020-07-08 13:47 ` Krzysztof Kozlowski
2020-07-13 5:13 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c5da6e3-d62e-9aa9-8c0c-e028c2c8c444@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=kishon@ti.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).