From: Tony Lindgren <tony@atomide.com>
To: Johan Hovold <johan@kernel.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, "Bjørn Mork" <bjorn@mork.no>,
"Dan Williams" <dcbw@redhat.com>,
"Marcel Partap" <mpartap@gmx.net>,
"Merlijn Wajer" <merlijn@wizzup.org>,
"Pavel Machek" <pavel@ucw.cz>,
"Sebastian Reichel" <sre@kernel.org>
Subject: USB: qcaux: Add Motorola modem UARTs
Date: Thu, 13 Dec 2018 06:37:08 -0800 [thread overview]
Message-ID: <20181213143708.GN39861@atomide.com> (raw)
* Johan Hovold <johan@kernel.org> [181213 12:46]:
> On Thu, Dec 06, 2018 at 07:48:23AM -0800, Tony Lindgren wrote:
> > Yes correct lsusb -v output below with five UARTs with ff/ff/ff and
> > two QMI ports that are already handled with an earlier commit
> > 4071898bf0f4 ("net: qmi_wwan: Add USB IDs for MDM6600 modem on
> > Motorola Droid 4").
>
> Isn't it four QMI ports even (interfaces 5 through 8)?
Oh right yes it's four QMI ports.
> > bDescriptorType 4
> > bInterfaceNumber 4
> > bAlternateSetting 0
> > bNumEndpoints 3
> > bInterfaceClass 255
> > bInterfaceSubClass 255
> > bInterfaceProtocol 255
> > iInterface 0
> > Endpoint Descriptor:
> > bLength 7
> > bDescriptorType 5
> > bEndpointAddress 0x85 EP 5 IN
> > bmAttributes 3
> > Transfer Type Interrupt
> > Synch Type None
> > Usage Type Data
> > wMaxPacketSize 0x0040 1x 64 bytes
> > bInterval 5
>
> Since the modem (AT) port here has an interrupt endpoint, you should add
> these device ids to the option driver which can handle that.
Oh OK will do.
> As the comment in qcaux suggests, that driver is intended for the diag
> port of some old devices where the modem port was handled by cdc-acm.
OK
> Also, if possible please include the more compact output of usb-devices
> (or /sys/kernel/debug/usb/devices) for the devices you have access to in
> the commit message.
Will do.
Thanks,
Tony
next reply other threads:[~2018-12-13 14:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 14:37 Tony Lindgren [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-12-13 12:46 USB: qcaux: Add Motorola modem UARTs Johan Hovold
2018-12-06 15:57 Tony Lindgren
2018-12-06 15:48 Tony Lindgren
2018-12-06 6:00 Johan Hovold
2018-12-06 1:54 Tony Lindgren
2018-12-05 6:17 Johan Hovold
2018-12-03 1:34 Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213143708.GN39861@atomide.com \
--to=tony@atomide.com \
--cc=bjorn@mork.no \
--cc=dcbw@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=mpartap@gmx.net \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).