From: Lucas Stach <l.stach@pengutronix.de>
To: Richard Leitner <richard.leitner@skidata.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Serge Semin <fancer.lancer@gmail.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
kernel@pengutronix.de, patchwork-lst@pengutronix.de
Subject: [PATCH 2/3] Revert "usb: usb251xb: Add US port lanes inversion property"
Date: Fri, 19 Jul 2019 10:44:06 +0200 [thread overview]
Message-ID: <20190719084407.28041-2-l.stach@pengutronix.de> (raw)
In-Reply-To: <20190719084407.28041-1-l.stach@pengutronix.de>
This property isn't needed and not yet used anywhere. The swap-dx-lanes
property is perfectly fine for doing the swap on the upstream port
lanes.
CC: stable@vger.kernel.org #5.2
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
drivers/usb/misc/usb251xb.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c
index 4d6ae3795a88..119aeb658c81 100644
--- a/drivers/usb/misc/usb251xb.c
+++ b/drivers/usb/misc/usb251xb.c
@@ -574,8 +574,6 @@ static int usb251xb_get_ofdata(struct usb251xb *hub,
hub->port_swap = USB251XB_DEF_PORT_SWAP;
usb251xb_get_ports_field(hub, "swap-dx-lanes", data->port_cnt,
&hub->port_swap);
- if (of_get_property(np, "swap-us-lanes", NULL))
- hub->port_swap |= BIT(0);
/* The following parameters are currently not exposed to devicetree, but
* may be as soon as needed.
--
2.20.1
next prev parent reply other threads:[~2019-07-19 8:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 8:44 [PATCH 1/3] Revert "usb: usb251xb: Add US lanes inversion dts-bindings" Lucas Stach
2019-07-19 8:44 ` Lucas Stach [this message]
2019-07-19 8:44 ` [PATCH 3/3] usb: usb251xb: Reallow swap-dx-lanes to apply to the upstream port Lucas Stach
2019-07-19 10:13 ` [PATCH 1/3] Revert "usb: usb251xb: Add US lanes inversion dts-bindings" Serge Semin
2019-07-22 7:46 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190719084407.28041-2-l.stach@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=patchwork-lst@pengutronix.de \
--cc=richard.leitner@skidata.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).