From: Johan Hovold <johan@kernel.org>
To: Matthew Michilot <mmichilot@gateworks.com>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthew Michilot <matthew.michilot@gmail.com>
Subject: Re: [PATCH] USB: serial: ftdi_sio: add support for FT232H CBUS gpios
Date: Tue, 13 Aug 2019 11:02:20 +0200 [thread overview]
Message-ID: <20190813090220.GC15556@localhost> (raw)
In-Reply-To: <20190808222348.4428-1-matthew.michilot@gmail.com>
On Thu, Aug 08, 2019 at 10:23:48PM +0000, Matthew Michilot wrote:
> Enable support for cbus gpios on FT232H. The cbus configuration is
> stored in one word in the EEPROM at byte-offset 0x1a with the mux
> config for ACBUS5, ACBUS6, ACBUS8 and ACBUS9 (only pins that can be
> configured as I/O mode).
>
> Tested using FT232H by configuring one ACBUS pin at a time.
>
> Review-by: Tim Harvey <tharvey@gateworks.com>
> Signed-off-by: Matthew Michilot <matthew.michilot@gmail.com>
Also make sure your SoB matches the From line.
Johan
next prev parent reply other threads:[~2019-08-13 9:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 22:23 [PATCH] USB: serial: ftdi_sio: add support for FT232H CBUS gpios Matthew Michilot
2019-08-13 9:00 ` Johan Hovold
2019-08-13 9:02 ` Johan Hovold [this message]
2019-08-15 17:40 ` [PATCH v2] " Matthew Michilot
2019-08-28 13:39 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813090220.GC15556@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthew.michilot@gmail.com \
--cc=mmichilot@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).