From: Rob Herring <robh@kernel.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Biju Das <biju.das@bp.renesas.com>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
Li Jun <jun.li@nxp.com>,
Badhri Jagan Sridharan <badhri@google.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Min Guo <min.guo@mediatek.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Linus Walleij <linus.walleij@linaro.org>,
Nagarjuna Kristam <nkristam@nvidia.com>
Subject: Re: [PATCH next v10 03/11] dt-bindings: usb: add binding for USB GPIO based connection detection driver
Date: Tue, 27 Aug 2019 13:31:54 -0500 [thread overview]
Message-ID: <20190827183154.GA10374@bogus> (raw)
In-Reply-To: <1566547041-20804-4-git-send-email-chunfeng.yun@mediatek.com>
On Fri, Aug 23, 2019 at 03:57:13PM +0800, Chunfeng Yun wrote:
> It's used to support dual role switch via GPIO when use Type-B
> receptacle, typically the USB ID pin is connected to an input
> GPIO, and also used to enable/disable device when the USB Vbus
> pin is connected to an input GPIO.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> v9~v10 no changes
>
> v8 changes:
> 1. rename the title
> 2. change the compatible as "linux,usb-conn-gpio" instead of
> "linux,typeb-conn-gpio"
I don't think that is an improvement. How about 'gpio-usb-b-connector'
to be consistent.
>
> v7 changes:
> 1. add description for device only mode
>
> v6 changes:
> 1. remove status and port nodes in example
> 2. make vbus-supply as optional property
>
> v5 changes:
> 1. treat type-B connector as child device of USB controller's, but not
> as a separate virtual device, suggested by Rob
> 2. put connector's port node under connector node, suggested by Rob
>
> v4 no changes
>
> v3 changes:
> 1. treat type-B connector as a virtual device, but not child device of
> USB controller's
>
> v2 changes:
> 1. new patch to make binding clear suggested by Hans
> ---
> .../devicetree/bindings/usb/usb-conn-gpio.txt | 31 +++++++++++++++++++
> 1 file changed, 31 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/usb-conn-gpio.txt
>
> diff --git a/Documentation/devicetree/bindings/usb/usb-conn-gpio.txt b/Documentation/devicetree/bindings/usb/usb-conn-gpio.txt
> new file mode 100644
> index 000000000000..d4d107fedc22
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/usb-conn-gpio.txt
> @@ -0,0 +1,31 @@
> +USB GPIO Based Connection Detection
> +
> +This is typically used to switch dual role mode from the USB ID pin connected
> +to an input GPIO, and also used to enable/disable device mode from the USB
> +Vbus pin connected to an input GPIO.
> +
> +Required properties:
> +- compatible : should include "linux,usb-conn-gpio" and "usb-b-connector".
> +- id-gpios, vbus-gpios : input gpios, either one of them must be present,
> + and both can be present as well.
> + see connector/usb-connector.txt
> +
> +Optional properties:
> +- vbus-supply : can be present if needed when supports dual role mode.
> + see connector/usb-connector.txt
> +
> +- Sub-nodes:
> + - port : can be present.
> + see graph.txt
> +
> +Example:
> +
> +&mtu3 {
> + connector {
> + compatible = "linux,usb-conn-gpio", "usb-b-connector";
> + label = "micro-USB";
'label' is for a human identifying a particular connector when there are
multiple (of the same type). So not a great example here.
> + type = "micro";
> + id-gpios = <&pio 12 GPIO_ACTIVE_HIGH>;
> + vbus-supply = <&usb_p0_vbus>;
> + };
> +};
> --
> 2.23.0
>
next prev parent reply other threads:[~2019-08-27 18:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 7:57 [PATCH next v10 00/11] add USB GPIO based connection detection driver Chunfeng Yun
2019-08-23 7:57 ` [PATCH next v10 01/11] dt-binding: usb: add usb-role-switch property Chunfeng Yun
2019-08-23 7:57 ` [PATCH next v10 02/11] dt-bindings: connector: add optional properties for Type-B Chunfeng Yun
2019-08-23 7:57 ` [PATCH next v10 03/11] dt-bindings: usb: add binding for USB GPIO based connection detection driver Chunfeng Yun
2019-08-23 10:07 ` Linus Walleij
2019-08-27 18:31 ` Rob Herring [this message]
2019-08-28 1:28 ` Chunfeng Yun
2019-08-23 7:57 ` [PATCH next v10 04/11] dt-bindings: usb: mtu3: add properties about USB Role Switch Chunfeng Yun
2019-08-23 7:57 ` [PATCH next v10 05/11] usb: roles: Introduce stubs for the exiting functions in role.h Chunfeng Yun
2019-08-23 7:57 ` [PATCH next v10 06/11] device connection: Add fwnode_connection_find_match() Chunfeng Yun
2019-08-23 7:57 ` [PATCH next v10 07/11] usb: roles: Add fwnode_usb_role_switch_get() function Chunfeng Yun
2019-08-23 7:57 ` [PATCH next v10 08/11] usb: roles: get usb-role-switch from parent Chunfeng Yun
2019-08-23 7:57 ` [PATCH next v10 09/11] usb: common: create Kconfig file Chunfeng Yun
2019-08-23 7:57 ` [PATCH next v10 10/11] usb: common: add USB GPIO based connection detection driver Chunfeng Yun
2019-08-23 7:57 ` [PATCH next v10 11/11] usb: mtu3: register a USB Role Switch for dual role mode Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827183154.GA10374@bogus \
--to=robh@kernel.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=andy.shevchenko@gmail.com \
--cc=badhri@google.com \
--cc=biju.das@bp.renesas.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jun.li@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=min.guo@mediatek.com \
--cc=nkristam@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).