From: Guenter Roeck <linux@roeck-us.net>
To: Christoph Hellwig <hch@lst.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lee Jones <lee.jones@linaro.org>,
Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] usb/ohci-sm501: remove the HCD_DMA flag
Date: Tue, 3 Sep 2019 04:37:53 -0700 [thread overview]
Message-ID: <20190903113753.GA20198@roeck-us.net> (raw)
In-Reply-To: <20190903084615.19161-2-hch@lst.de>
On Tue, Sep 03, 2019 at 10:46:10AM +0200, Christoph Hellwig wrote:
> This driver doesn't support normal DMA, only direct access to its
> local memory. Remove the HCD_DMA flag to properly express that fact.
>
> Fixes: 1e4946c4412e ("usb: add a HCD_DMA flag instead of guestimating DMA capabilities")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Tested-by: Guenter Roeck <linux@roeck-us.net>
on top of next-20190903.
Thanks!
Guenter
> ---
> drivers/usb/host/ohci-sm501.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ohci-sm501.c b/drivers/usb/host/ohci-sm501.c
> index 0b2aea6e28d4..c158cda9e4b9 100644
> --- a/drivers/usb/host/ohci-sm501.c
> +++ b/drivers/usb/host/ohci-sm501.c
> @@ -49,7 +49,7 @@ static const struct hc_driver ohci_sm501_hc_driver = {
> * generic hardware linkage
> */
> .irq = ohci_irq,
> - .flags = HCD_USB11 | HCD_DMA | HCD_MEMORY,
> + .flags = HCD_USB11 | HCD_MEMORY,
>
> /*
> * basic lifecycle operations
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-09-03 11:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 8:46 usb dma_mask fixups Christoph Hellwig
2019-09-03 8:46 ` [PATCH 1/6] usb/ohci-sm501: remove the HCD_DMA flag Christoph Hellwig
2019-09-03 11:37 ` Guenter Roeck [this message]
2019-09-03 13:27 ` Greg Kroah-Hartman
2019-09-03 8:46 ` [PATCH 2/6] usb/ohci-tmio: " Christoph Hellwig
2019-09-03 8:46 ` [PATCH 3/6] usb-storage: use hcd_uses_dma to check for DMA capabilities Christoph Hellwig
2019-09-03 8:46 ` [PATCH 4/6] usb: remove a stale comment in hcd_alloc_coherent Christoph Hellwig
2019-09-03 8:46 ` [PATCH 5/6] usb: remove commented out dma wrappers Christoph Hellwig
2019-09-03 8:46 ` [PATCH 6/6] mfd: don't select DMA_DECLARE_COHERENT for the sm501 and tc6393xb drivers Christoph Hellwig
2019-09-03 13:16 ` usb dma_mask fixups Greg Kroah-Hartman
2019-09-04 8:57 ` Lee Jones
2019-09-04 10:00 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903113753.GA20198@roeck-us.net \
--to=linux@roeck-us.net \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).