From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ajay Gupta <ajayg@nvidia.com>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 12/18] usb: typec: ucsi: acpi: Move to the new API
Date: Mon, 4 Nov 2019 11:07:15 +0200 [thread overview]
Message-ID: <20191104090715.GB29493@kuha.fi.intel.com> (raw)
In-Reply-To: <d40c258c-790a-2412-94f2-c664a11eade2@roeck-us.net>
Hi,
On Sat, Nov 02, 2019 at 09:31:29AM -0700, Guenter Roeck wrote:
> > -static int ucsi_acpi_cmd(struct ucsi_ppm *ppm, struct ucsi_control *ctrl)
> > +static int ucsi_acpi_read(struct ucsi *ucsi, unsigned int offset,
> > + void *val, size_t val_len)
> > {
> > - struct ucsi_acpi *ua = container_of(ppm, struct ucsi_acpi, ppm);
> > + struct ucsi_acpi *ua = ucsi_get_drvdata(ucsi);
> > + int ret;
> > +
> > + ret = ucsi_acpi_dsm(ua, UCSI_DSM_FUNC_READ);
> > + if (ret)
> > + return ret;
> > +
> > + memcpy(val, (const void __force *)(ua->base + offset), val_len);
> > +
>
> Would it be better to use memcpy_fromio() and memcpy_toio() if
> ua->base indeed points to iomem ?
No, it's not really iomem. It's just supplied to the driver as such.
thanks,
--
heikki
next prev parent reply other threads:[~2019-11-04 9:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 8:23 [PATCH v3 00/18] usb: typec: API improvements Heikki Krogerus
2019-10-25 8:23 ` [PATCH v3 01/18] usb: typec: Copy everything from struct typec_capability during registration Heikki Krogerus
2019-10-25 8:23 ` [PATCH v3 02/18] usb: typec: Introduce typec_get_drvdata() Heikki Krogerus
2019-10-25 8:23 ` [PATCH v3 03/18] usb: typec: Separate the operations vector Heikki Krogerus
2019-10-25 8:23 ` [PATCH v3 04/18] usb: typec: tcpm: Start using struct typec_operations Heikki Krogerus
2019-10-25 8:23 ` [PATCH v3 05/18] usb: typec: tps6598x: " Heikki Krogerus
2019-10-25 8:23 ` [PATCH v3 06/18] usb: typec: ucsi: " Heikki Krogerus
2019-10-25 8:23 ` [PATCH v3 07/18] usb: typec: hd3ss3220: " Heikki Krogerus
2019-10-25 8:23 ` [PATCH v3 08/18] usb: typec: Remove the callback members from struct typec_capability Heikki Krogerus
2019-10-25 8:23 ` [PATCH v3 09/18] usb: typec: Remove unused " Heikki Krogerus
2019-10-25 8:23 ` [PATCH v3 10/18] usb: typec: hd3ss3220: Give the connector fwnode to the port device Heikki Krogerus
2019-11-02 16:11 ` Guenter Roeck
2019-11-04 7:50 ` Biju Das
2019-10-25 8:23 ` [PATCH v3 11/18] usb: typec: ucsi: Simplified registration and I/O API Heikki Krogerus
2019-11-02 16:21 ` Guenter Roeck
2019-10-25 8:23 ` [PATCH v3 12/18] usb: typec: ucsi: acpi: Move to the new API Heikki Krogerus
2019-11-02 16:31 ` Guenter Roeck
2019-11-04 9:07 ` Heikki Krogerus [this message]
2019-10-25 8:23 ` [PATCH v3 13/18] usb: typec: ucsi: ccg: " Heikki Krogerus
2019-11-02 16:34 ` Guenter Roeck
2019-11-04 8:45 ` Heikki Krogerus
2019-10-25 8:23 ` [PATCH v3 14/18] usb: typec: ucsi: Remove the old API Heikki Krogerus
2019-10-25 8:23 ` [PATCH v3 15/18] usb: typec: ucsi: Remove struct ucsi_control Heikki Krogerus
2019-11-02 17:00 ` Guenter Roeck
2019-10-25 8:23 ` [PATCH v3 16/18] usb: typec: ucsi: Remove all bit-fields Heikki Krogerus
2019-10-25 8:23 ` [PATCH v3 17/18] usb: typec: ucsi: New error codes Heikki Krogerus
2019-10-25 8:23 ` [PATCH v3 18/18] usb: typec: ucsi: Optimise ucsi_unregister() Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104090715.GB29493@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=ajayg@nvidia.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).