From: Thierry Reding <treding@nvidia.com>
To: Mao Wenan <maowenan@huawei.com>
Cc: <felipe.balbi@linux.intel.com>, <gregkh@linuxfoundation.org>,
<nkristam@nvidia.com>, <arnd@arndb.de>, <johan@kernel.org>,
<krzk@kernel.org>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH v2 -next] usb: gadget: Add dependency for USB_TEGRA_XUDC
Date: Mon, 4 Nov 2019 14:52:06 +0100 [thread overview]
Message-ID: <20191104135206.GC996639@ulmo> (raw)
In-Reply-To: <20191104112104.195329-1-maowenan@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 999 bytes --]
On Mon, Nov 04, 2019 at 07:21:04PM +0800, Mao Wenan wrote:
> If CONFIG_USB_TEGRA_XUDC=y and CONFIG_USB_ROLE_SWITCH=m,
> below erros can be seen:
> drivers/usb/gadget/udc/tegra-xudc.o: In function `tegra_xudc_remove':
> tegra-xudc.c:(.text+0x6b0): undefined reference to `usb_role_switch_unregister'
> drivers/usb/gadget/udc/tegra-xudc.o: In function `tegra_xudc_probe':
> tegra-xudc.c:(.text+0x1b88): undefined reference to `usb_role_switch_register'
> drivers/usb/gadget/udc/tegra-xudc.o: In function `tegra_xudc_usb_role_sw_work':
> tegra-xudc.c:(.text+0x5ecc): undefined reference to `usb_role_switch_get_role'
>
> It should select USB_ROLE_SWITCH for UDC driver.
>
> Fixes: 49db427232fe ("usb: gadget: Add UDC driver for tegra XUSB device mode controller")
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> v2: change 'depends on' to 'select'.
> drivers/usb/gadget/udc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-11-04 13:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 2:59 [PATCH -next] usb: gadget: Add dependency for USB_TEGRA_XUDC Mao Wenan
2019-11-04 10:04 ` Thierry Reding
2019-11-04 10:50 ` maowenan
2019-11-04 11:21 ` [PATCH v2 " Mao Wenan
2019-11-04 13:52 ` Thierry Reding [this message]
2019-11-04 13:53 ` [PATCH " Thierry Reding
2019-11-04 14:48 ` [PATCH -next] usb: roles: Hide option USB_ROLE_SWITCH Mao Wenan
2019-11-05 12:42 ` Heikki Krogerus
2019-11-05 13:16 ` Dan Carpenter
2019-11-05 15:26 ` Heikki Krogerus
2019-11-06 11:23 ` Dan Carpenter
2019-11-05 12:37 ` [PATCH -next] usb: gadget: Add dependency for USB_TEGRA_XUDC Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104135206.GC996639@ulmo \
--to=treding@nvidia.com \
--cc=arnd@arndb.de \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maowenan@huawei.com \
--cc=nkristam@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).