From: Rob Herring <robh@kernel.org>
To: Doug Anderson <dianders@chromium.org>
Cc: "Sandeep Maheswaram (Temp)" <sanm@codeaurora.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Rutland <mark.rutland@arm.com>,
Felipe Balbi <balbi@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
linux-usb@vger.kernel.org,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Manu Gautam <mgautam@codeaurora.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: usb: qcom,dwc3: Convert USB DWC3 bindings
Date: Wed, 18 Dec 2019 16:13:10 -0600 [thread overview]
Message-ID: <20191218221310.GA4624@bogus> (raw)
In-Reply-To: <CAD=FV=UER4zt=z3XWEzNt5v2oe8V=z6Hb-Wm-2BzuWtuHmYg-A@mail.gmail.com>
On Wed, Dec 18, 2019 at 10:37:53AM -0800, Doug Anderson wrote:
> Hi,
>
> On Wed, Dec 18, 2019 at 4:41 AM Sandeep Maheswaram (Temp)
> <sanm@codeaurora.org> wrote:
> > + assigned-clock-rates:
> > + description:
> > + Should be 19.2MHz (19200000) for MOCK_UTMI_CLK
> > + >=125MHz (125000000) for MASTER_CLK in SS mode
> > + >=60MHz (60000000) for MASTER_CLK in HS mode
> > + maxItems: 2
> >
> > You can still express some limits here even if we don't go all out
> > with the "oneOf". AKA I think this is better:
> >
> > assigned-clock-rates:
> > items:
> > - const: 19200000
> > - minimum: 60000000
> > description: >= 60 MHz in HS mode, >= 125 MHz in SS mode
> >
> > Facing error when i add as above.
> > properties:assigned-clock-rates: {'items': [{'const': 19200000}, {'minimum': 60000000}]} is not valid under any of the given schemas
> > Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/usb/qcom,dwc3.example.dts' failed
Update dtschema and you should get a better error message now.
I believe the problem is we require both minimum and maximum to be
specified or none. Maybe we should relax that, but OTOH I doubt 4GHz is
valid.
Rob
next prev parent reply other threads:[~2019-12-18 22:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 5:39 [PATCH v3 0/2] Add USB DWC3 support for SC7180 Sandeep Maheswaram
2019-12-16 5:39 ` [PATCH v3 1/2] dt-bindings: usb: qcom,dwc3: Convert USB DWC3 bindings Sandeep Maheswaram
2019-12-16 18:09 ` Stephen Boyd
2019-12-17 19:22 ` Doug Anderson
[not found] ` <e901331b-456c-f3ed-6717-e5bf24778c57@codeaurora.org>
2019-12-18 18:39 ` Doug Anderson
2019-12-17 19:14 ` Doug Anderson
[not found] ` <6d8c979f-daa3-3b40-f29c-cca5a2f8f1c8@codeaurora.org>
2019-12-18 18:37 ` Doug Anderson
2019-12-18 22:13 ` Rob Herring [this message]
2019-12-26 5:56 ` Sandeep Maheswaram (Temp)
2020-01-07 3:47 ` Doug Anderson
2019-12-16 5:39 ` [PATCH v3 2/2] dt-bindings: usb: qcom,dwc3: Add compatible for SC7180 Sandeep Maheswaram
2019-12-16 18:09 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218221310.GA4624@bogus \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgautam@codeaurora.org \
--cc=sanm@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).