From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-usb@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH v1] usb: core: Add ACPI support for USB interfaces
Date: Tue, 24 Mar 2020 07:26:35 +0100 [thread overview]
Message-ID: <20200324062635.GB1977781@kroah.com> (raw)
In-Reply-To: <20200323195543.51050-1-andriy.shevchenko@linux.intel.com>
On Mon, Mar 23, 2020 at 09:55:43PM +0200, Andy Shevchenko wrote:
> The ACPI companion of the device has to be set for USB interfaces
> in order to read and attach the properties described in the ACPI table.
> Use ACPI_COMPANION_SET macro to set this.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/usb/core/message.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
> index 5adf489428aa..d5f834f16993 100644
> --- a/drivers/usb/core/message.c
> +++ b/drivers/usb/core/message.c
> @@ -5,6 +5,7 @@
> * Released under the GPLv2 only.
> */
>
> +#include <linux/acpi.h>
> #include <linux/pci.h> /* for scatterlist macros */
> #include <linux/usb.h>
> #include <linux/module.h>
> @@ -1941,6 +1942,7 @@ int usb_set_configuration(struct usb_device *dev, int configuration)
> intf->dev.of_node = usb_of_get_interface_node(dev,
> configuration, ifnum);
> }
> + ACPI_COMPANION_SET(&intf->dev, ACPI_COMPANION(&dev->dev));
> intf->dev.driver = NULL;
> intf->dev.bus = &usb_bus_type;
> intf->dev.type = &usb_if_device_type;
And what does this "fix"?
Is this a new feature, what isn't working today without this change?
And if it is a fix, should it be backported to older kernels, how far?
greg k-h
next prev parent reply other threads:[~2020-03-24 6:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 19:55 [PATCH v1] usb: core: Add ACPI support for USB interfaces Andy Shevchenko
2020-03-24 6:26 ` Greg Kroah-Hartman [this message]
2020-03-24 9:00 ` Andy Shevchenko
2020-03-24 9:13 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324062635.GB1977781@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).