Hi Peter, I love your patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on balbi-usb/testing/next next-20200522] [cannot apply to shawnguo/for-next v5.7-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Peter-Chen/usb-some-PM-changes-for-cdns3-and-xhci-plat/20200524-072451 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: s390-randconfig-s002-20200524 (attached as .config) compiler: s390-linux-gcc (GCC) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.1-240-gf0fe1cd9-dirty # save the attached .config to linux build tree make W=1 C=1 ARCH=s390 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All warnings (new ones prefixed by >>, old ones prefixed by <<): >> drivers/usb/cdns3/cdns3-imx.c:150:12: warning: 'cdns_imx_platform_suspend' used but never defined 150 | static int cdns_imx_platform_suspend(struct device *dev, | ^~~~~~~~~~~~~~~~~~~~~~~~~ vim +/cdns_imx_platform_suspend +150 drivers/usb/cdns3/cdns3-imx.c 149 > 150 static int cdns_imx_platform_suspend(struct device *dev, 151 bool suspend, bool wakeup); 152 static struct cdns3_platform_data cdns_imx_pdata = { 153 .platform_suspend = cdns_imx_platform_suspend, 154 }; 155 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org