From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0DD0C433DF for ; Fri, 16 Oct 2020 17:00:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 529CE21527 for ; Fri, 16 Oct 2020 17:00:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602867611; bh=0uL85Y3JhosVvRhToT37s3xmSi3OuysTpin17Qv6xI0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=KUCvtn2QJgjLms2Jon7WEFhIFU8XymhhiCdTCB6gAHZqhdvAGw0wY3aGJl/e3quwB tm7UdinX9/bok1vSYUZdhIY/osM/Zme2Baq+eX46tC/Oe0s92C9Ncn5zGEppcYZVsT IESrSPz1dn9z7d7UlBeJDBiHjoFzsUOjiiVeepa0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2410822AbgJPRAI (ORCPT ); Fri, 16 Oct 2020 13:00:08 -0400 Received: from mail-oo1-f66.google.com ([209.85.161.66]:41070 "EHLO mail-oo1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2409137AbgJPRAH (ORCPT ); Fri, 16 Oct 2020 13:00:07 -0400 Received: by mail-oo1-f66.google.com with SMTP id o184so769397ooo.8; Fri, 16 Oct 2020 10:00:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=03V5eadrj0h1F2pFsncYCDBW4/1TS8rmfiq/2NLYUyU=; b=LgHJ5MDWbxgPqktpaKJP4924LMC6BxiTWZFYqjpv8wiAjxzbE9sB7anRSEtmsSzfSC jDmplHNAErXzBmNpeza+GiehfZrcTzVhDHNckakiR+AXLnk3gsiZqLuVg7KkkXk4Pnxe MY+jBL2YaOQARL6/cxSFGG/0zKX8Wp/zQEy3uyYJIYD//OcPOKlmRM86FzHRo+kzyKJS e3hq8u2JppcXg+f+vPU55UYH21t2joeAfxHjou4bd2nkeCUroQnnrUBlxndedyK0yGSw XwKd4ZtuuZN5yBQHjl5T5CaapldCupcXjSm04ezARwC1r3tqBvuSR557At/KWFFW28m4 xaug== X-Gm-Message-State: AOAM5331UsTYee0kjerIQXfbUDXhGo1CPtlPMgAzjzhMY+Xq3ce/9ZBD SE0rQakPE9FZciAtkjl23Q== X-Google-Smtp-Source: ABdhPJymBTUe6iAsdy5LQo71U6LggVYOT2y9eqtpe/ffg/4HjlPRuMq1hKnFJ9O3LOVeycHTFsJt0w== X-Received: by 2002:a4a:972c:: with SMTP id u41mr3569279ooi.10.1602867605572; Fri, 16 Oct 2020 10:00:05 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id d64sm1181772oia.11.2020.10.16.10.00.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Oct 2020 10:00:04 -0700 (PDT) Received: (nullmailer pid 1573907 invoked by uid 1000); Fri, 16 Oct 2020 17:00:03 -0000 Date: Fri, 16 Oct 2020 12:00:03 -0500 From: Rob Herring To: Chunfeng Yun Cc: Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Kishon Vijay Abraham I , Vinod Koul , Matthias Brugger , Greg Kroah-Hartman , Mauro Carvalho Chehab , "David S . Miller" , CK Hu , Stanley Chu , Min Guo , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v2 1/8] dt-bindings: phy: convert phy-mtk-xsphy.txt to YAML schema Message-ID: <20201016170003.GA1562276@bogus> References: <20201013085207.17749-1-chunfeng.yun@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201013085207.17749-1-chunfeng.yun@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, Oct 13, 2020 at 04:52:00PM +0800, Chunfeng Yun wrote: > Convert phy-mtk-xsphy.txt to YAML schema mediatek,xsphy.yaml > > Signed-off-by: Chunfeng Yun > --- > v2: modify description and compatible definition suggested by Rob > --- > .../bindings/phy/mediatek,xsphy.yaml | 200 ++++++++++++++++++ > .../devicetree/bindings/phy/phy-mtk-xsphy.txt | 109 ---------- > 2 files changed, 200 insertions(+), 109 deletions(-) > create mode 100644 Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml > delete mode 100644 Documentation/devicetree/bindings/phy/phy-mtk-xsphy.txt > > diff --git a/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml > new file mode 100644 > index 000000000000..86511f19277a > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml > @@ -0,0 +1,200 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (c) 2020 MediaTek > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/mediatek,xsphy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek XS-PHY Controller Device Tree Bindings > + > +maintainers: > + - Chunfeng Yun > + > +description: | > + The XS-PHY controller supports physical layer functionality for USB3.1 > + GEN2 controller on MediaTek SoCs. > + > + Banks layout of xsphy > + ---------------------------------- > + port offset bank > + u2 port0 0x0000 MISC > + 0x0100 FMREG > + 0x0300 U2PHY_COM > + u2 port1 0x1000 MISC > + 0x1100 FMREG > + 0x1300 U2PHY_COM > + u2 port2 0x2000 MISC > + ... > + u31 common 0x3000 DIG_GLB > + 0x3100 PHYA_GLB > + u31 port0 0x3400 DIG_LN_TOP > + 0x3500 DIG_LN_TX0 > + 0x3600 DIG_LN_RX0 > + 0x3700 DIG_LN_DAIF > + 0x3800 PHYA_LN > + u31 port1 0x3a00 DIG_LN_TOP > + 0x3b00 DIG_LN_TX0 > + 0x3c00 DIG_LN_RX0 > + 0x3d00 DIG_LN_DAIF > + 0x3e00 PHYA_LN > + ... > + DIG_GLB & PHYA_GLB are shared by U31 ports. > + > +properties: > + $nodename: > + pattern: "^xs-phy@[0-9a-f]+$" > + > + compatible: > + items: > + - enum: > + - mediatek,mt3611-xsphy > + - mediatek,mt3612-xsphy > + - const: mediatek,xsphy > + > + reg: > + description: | > + Register shared by multiple U3 ports, exclude port's private register, > + if only U2 ports provided, shouldn't use the property. > + maxItems: 1 > + > + "#address-cells": > + enum: [1, 2] > + > + "#size-cells": > + enum: [1, 2] > + > + ranges: true > + > + mediatek,src-ref-clk-mhz: > + description: > + Frequency of reference clock for slew rate calibrate > + $ref: /schemas/types.yaml#/definitions/uint32 Properties with a standard unit suffix don't need a type. > + default: 26 > + > + mediatek,src-coef: > + description: > + Coefficient for slew rate calibrate, depends on SoC process > + $ref: /schemas/types.yaml#/definitions/uint32 > + default: 17 > + > +# Required child node: > +patternProperties: > + "^usb-phy@[0-9a-f]+$": > + type: object > + description: | > + A sub-node is required for each port the controller provides. > + Address range information including the usual 'reg' property > + is used inside these nodes to describe the controller's topology. > + > + properties: > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: Reference clock, (HS is 48Mhz, SS/P is 24~27Mhz) > + > + clock-names: > + items: > + - const: ref > + > + "#phy-cells": > + const: 1 > + description: | > + The cells contain the following arguments. > + > + - description: The PHY type > + enum: > + - PHY_TYPE_USB2 > + - PHY_TYPE_USB3 > + > + #The following optional vendor properties are only for debug or HQA test > + mediatek,eye-src: > + description: > + The value of slew rate calibrate (U2 phy) > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 1 > + maximum: 7 > + > + mediatek,eye-vrt: > + description: > + The selection of VRT reference voltage (U2 phy) > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 1 > + maximum: 7 > + > + mediatek,eye-term: > + description: > + The selection of HS_TX TERM reference voltage (U2 phy) > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 1 > + maximum: 7 > + > + mediatek,efuse-intr: > + description: > + The selection of Internal Resistor (U2/U3 phy) > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 1 > + maximum: 63 > + > + mediatek,efuse-tx-imp: > + description: > + The selection of TX Impedance (U3 phy) > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 1 > + maximum: 31 > + > + mediatek,efuse-rx-imp: > + description: > + The selection of RX Impedance (U3 phy) > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 1 > + maximum: 31 > + > + required: > + - reg > + - clocks > + - clock-names > + - "#phy-cells" > + > + additionalProperties: false > + > +required: > + - compatible > + - "#address-cells" > + - "#size-cells" > + - ranges > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + u3phy: xs-phy@11c40000 { > + compatible = "mediatek,mt3611-xsphy", "mediatek,xsphy"; > + reg = <0x11c43000 0x0200>; > + mediatek,src-ref-clk-mhz = <26>; > + mediatek,src-coef = <17>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + u2port0: usb-phy@11c40000 { > + reg = <0x11c40000 0x0400>; > + clocks = <&clk48m>; > + clock-names = "ref"; > + mediatek,eye-src = <4>; > + #phy-cells = <1>; > + }; > + > + u3port0: usb-phy@11c43000 { > + reg = <0x11c43400 0x0500>; > + clocks = <&clk26m>; > + clock-names = "ref"; > + mediatek,efuse-intr = <28>; > + #phy-cells = <1>; > + }; > + }; > + > +... > diff --git a/Documentation/devicetree/bindings/phy/phy-mtk-xsphy.txt b/Documentation/devicetree/bindings/phy/phy-mtk-xsphy.txt > deleted file mode 100644 > index e7caefa0b9c2..000000000000 > --- a/Documentation/devicetree/bindings/phy/phy-mtk-xsphy.txt > +++ /dev/null > @@ -1,109 +0,0 @@ > -MediaTek XS-PHY binding > --------------------------- > - > -The XS-PHY controller supports physical layer functionality for USB3.1 > -GEN2 controller on MediaTek SoCs. > - > -Required properties (controller (parent) node): > - - compatible : should be "mediatek,-xsphy", "mediatek,xsphy", > - soc-model is the name of SoC, such as mt3611 etc; > - when using "mediatek,xsphy" compatible string, you need SoC specific > - ones in addition, one of: > - - "mediatek,mt3611-xsphy" > - > - - #address-cells, #size-cells : should use the same values as the root node > - - ranges: must be present > - > -Optional properties (controller (parent) node): > - - reg : offset and length of register shared by multiple U3 ports, > - exclude port's private register, if only U2 ports provided, > - shouldn't use the property. > - - mediatek,src-ref-clk-mhz : u32, frequency of reference clock for slew rate > - calibrate > - - mediatek,src-coef : u32, coefficient for slew rate calibrate, depends on > - SoC process > - > -Required nodes : a sub-node is required for each port the controller > - provides. Address range information including the usual > - 'reg' property is used inside these nodes to describe > - the controller's topology. > - > -Required properties (port (child) node): > -- reg : address and length of the register set for the port. > -- clocks : a list of phandle + clock-specifier pairs, one for each > - entry in clock-names > -- clock-names : must contain > - "ref": 48M reference clock for HighSpeed analog phy; and 26M > - reference clock for SuperSpeedPlus analog phy, sometimes is > - 24M, 25M or 27M, depended on platform. > -- #phy-cells : should be 1 > - cell after port phandle is phy type from: > - - PHY_TYPE_USB2 > - - PHY_TYPE_USB3 > - > -The following optional properties are only for debug or HQA test > -Optional properties (PHY_TYPE_USB2 port (child) node): > -- mediatek,eye-src : u32, the value of slew rate calibrate > -- mediatek,eye-vrt : u32, the selection of VRT reference voltage > -- mediatek,eye-term : u32, the selection of HS_TX TERM reference voltage > -- mediatek,efuse-intr : u32, the selection of Internal Resistor > - > -Optional properties (PHY_TYPE_USB3 port (child) node): > -- mediatek,efuse-intr : u32, the selection of Internal Resistor > -- mediatek,efuse-tx-imp : u32, the selection of TX Impedance > -- mediatek,efuse-rx-imp : u32, the selection of RX Impedance > - > -Banks layout of xsphy > -------------------------------------------------------------- > -port offset bank > -u2 port0 0x0000 MISC > - 0x0100 FMREG > - 0x0300 U2PHY_COM > -u2 port1 0x1000 MISC > - 0x1100 FMREG > - 0x1300 U2PHY_COM > -u2 port2 0x2000 MISC > - ... > -u31 common 0x3000 DIG_GLB > - 0x3100 PHYA_GLB > -u31 port0 0x3400 DIG_LN_TOP > - 0x3500 DIG_LN_TX0 > - 0x3600 DIG_LN_RX0 > - 0x3700 DIG_LN_DAIF > - 0x3800 PHYA_LN > -u31 port1 0x3a00 DIG_LN_TOP > - 0x3b00 DIG_LN_TX0 > - 0x3c00 DIG_LN_RX0 > - 0x3d00 DIG_LN_DAIF > - 0x3e00 PHYA_LN > - ... > - > -DIG_GLB & PHYA_GLB are shared by U31 ports. > - > -Example: > - > -u3phy: usb-phy@11c40000 { > - compatible = "mediatek,mt3611-xsphy", "mediatek,xsphy"; > - reg = <0 0x11c43000 0 0x0200>; > - mediatek,src-ref-clk-mhz = <26>; > - mediatek,src-coef = <17>; > - #address-cells = <2>; > - #size-cells = <2>; > - ranges; > - > - u2port0: usb-phy@11c40000 { > - reg = <0 0x11c40000 0 0x0400>; > - clocks = <&clk48m>; > - clock-names = "ref"; > - mediatek,eye-src = <4>; > - #phy-cells = <1>; > - }; > - > - u3port0: usb-phy@11c43000 { > - reg = <0 0x11c43400 0 0x0500>; > - clocks = <&clk26m>; > - clock-names = "ref"; > - mediatek,efuse-intr = <28>; > - #phy-cells = <1>; > - }; > -}; > -- > 2.18.0